public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Samuel Thibault <sthibaul@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] hurd: Fix longjmp check for sigstate
Date: Sat, 18 Jul 2020 13:14:04 +0000 (GMT)	[thread overview]
Message-ID: <20200718131404.3A47D3857C44@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5baad9a6f948b7822db3392097e7d79e9e018655

commit 5baad9a6f948b7822db3392097e7d79e9e018655
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Sat Jul 18 15:12:56 2020 +0200

    hurd: Fix longjmp check for sigstate
    
    * sysdeps/mach/hurd/i386/____longjmp_chk.S,__longjmp.S: Properly check for
    sigstate being NULL.

Diff:
---
 sysdeps/mach/hurd/i386/____longjmp_chk.S | 2 +-
 sysdeps/mach/hurd/i386/__longjmp.S       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sysdeps/mach/hurd/i386/____longjmp_chk.S b/sysdeps/mach/hurd/i386/____longjmp_chk.S
index 5131386c60..a746a4f2ba 100644
--- a/sysdeps/mach/hurd/i386/____longjmp_chk.S
+++ b/sysdeps/mach/hurd/i386/____longjmp_chk.S
@@ -67,7 +67,7 @@ ENTRY (____longjmp_chk)
 
 	movl	%gs:SIGSTATE_OFFSET, %edi
 	testl	%edi, %edi
-	jnz	.Lok		/* sigstate not initialized yet */
+	jz	.Lok		/* sigstate not initialized yet */
 
 	testl	$SS_ONSTACK, (HURD_SIGSTATE__SIGALTSTACK__OFFSET + SIGALTSTACK__SS_FLAGS__OFFSET)(%edi)
 	jnz	.Lonstack
diff --git a/sysdeps/mach/hurd/i386/__longjmp.S b/sysdeps/mach/hurd/i386/__longjmp.S
index 73bbff9826..af788ede0f 100644
--- a/sysdeps/mach/hurd/i386/__longjmp.S
+++ b/sysdeps/mach/hurd/i386/__longjmp.S
@@ -45,7 +45,7 @@ ENTRY (__longjmp)
 
 	movl	%gs:SIGSTATE_OFFSET, %edi
 	testl	%edi, %edi
-	jnz	.Lok		/* sigstate not initialized yet */
+	jz	.Lok		/* sigstate not initialized yet */
 
 	testl	$SS_ONSTACK, (HURD_SIGSTATE__SIGALTSTACK__OFFSET + SIGALTSTACK__SS_FLAGS__OFFSET)(%edi)
 	jz	.Lok


                 reply	other threads:[~2020-07-18 13:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200718131404.3A47D3857C44@sourceware.org \
    --to=sthibaul@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).