public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Stan Shebs <shebs@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/google/grte/v5-2.27/master] Let time and gettimeofday use vdso by removing old clang workaround
Date: Tue,  6 Oct 2020 20:08:51 +0000 (GMT)	[thread overview]
Message-ID: <20201006200851.A0A4F3857013@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=52de78c8f5d2d72e32140560cb4470f29617344f

commit 52de78c8f5d2d72e32140560cb4470f29617344f
Author: Stan Shebs <stanshebs@google.com>
Date:   Tue Oct 6 13:08:18 2020 -0700

    Let time and gettimeofday use vdso by removing old clang workaround

Diff:
---
 sysdeps/unix/sysv/linux/x86/gettimeofday.c | 3 +--
 sysdeps/unix/sysv/linux/x86/time.c         | 7 +------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/x86/gettimeofday.c b/sysdeps/unix/sysv/linux/x86/gettimeofday.c
index 614971bffb..e125859c1a 100644
--- a/sysdeps/unix/sysv/linux/x86/gettimeofday.c
+++ b/sysdeps/unix/sysv/linux/x86/gettimeofday.c
@@ -18,8 +18,7 @@
 
 #include <sys/time.h>
 
-/* Clang ifunc support works, but differently enough that this code breaks.  */
-#if defined(SHARED) && !defined(__clang__)
+#ifdef SHARED
 
 # include <dl-vdso.h>
 # include <errno.h>
diff --git a/sysdeps/unix/sysv/linux/x86/time.c b/sysdeps/unix/sysv/linux/x86/time.c
index 8992656bad..d19cccd6f6 100644
--- a/sysdeps/unix/sysv/linux/x86/time.c
+++ b/sysdeps/unix/sysv/linux/x86/time.c
@@ -18,8 +18,7 @@
 
 #include <time.h>
 
-/* Clang ifunc support works, but differently enough that this code breaks.  */
-#if defined(SHARED) && !defined(__clang__)
+#ifdef SHARED
 
 #include <dl-vdso.h>
 #include <errno.h>
@@ -58,7 +57,3 @@ time (time_t *t)
 }
 
 #endif
-
-#if defined(__clang__)
-libc_hidden_weak (time)
-#endif


             reply	other threads:[~2020-10-06 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 20:08 Stan Shebs [this message]
2021-08-28  0:37 Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006200851.A0A4F3857013@sourceware.org \
    --to=shebs@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).