public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] resolv: Serialize processing in resolv/tst-resolv-txnid-collision
Date: Thu, 15 Oct 2020 10:34:42 +0000 (GMT)	[thread overview]
Message-ID: <20201015103442.9D0153857804@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b8b53b338f6da91e86d115a39da860cefac736ad

commit b8b53b338f6da91e86d115a39da860cefac736ad
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Oct 15 12:33:13 2020 +0200

    resolv: Serialize processing in resolv/tst-resolv-txnid-collision
    
    When switching name servers, response processing by two server
    threads clobbers the global test state.  (There is still some
    risk that this test is negatively impact by packet drops and
    packet reordering, but this applies to many of the resolver tests
    and is difficult to avoid.)
    
    Fixes commit f1f00c072138af90ae6da180f260111f09afe7a3 ("resolv:
    Handle transaction ID collisions in parallel queries (bug 26600)").

Diff:
---
 resolv/tst-resolv-txnid-collision.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/resolv/tst-resolv-txnid-collision.c b/resolv/tst-resolv-txnid-collision.c
index 611d37362f..189b76f126 100644
--- a/resolv/tst-resolv-txnid-collision.c
+++ b/resolv/tst-resolv-txnid-collision.c
@@ -309,6 +309,11 @@ do_test (void)
     ((struct resolv_redirect_config)
      {
        .response_callback = response,
+
+       /* The response callback use global state (the previous_*
+          variables), and query processing must therefore be
+          serialized.  */
+       .single_thread_udp = true,
      });
 
   for (int rcode = 0; rcode <= 5; ++rcode)


                 reply	other threads:[~2020-10-15 10:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015103442.9D0153857804@sourceware.org \
    --to=fw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).