From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1105) id 4303E383E809; Fri, 30 Oct 2020 21:40:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4303E383E809 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Joseph Myers To: glibc-cvs@sourceware.org Subject: [glibc] Disable spurious -Warray-bounds for ypclnt.c (bug 26687) X-Act-Checkin: glibc X-Git-Author: Joseph Myers X-Git-Refname: refs/heads/master X-Git-Oldrev: 5c3b0374ebe0aa4b0a434c0addb4c455886a0986 X-Git-Newrev: 882774658cb8daee4c16677a3fd674f6052cc157 Message-Id: <20201030214059.4303E383E809@sourceware.org> Date: Fri, 30 Oct 2020 21:40:59 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 21:40:59 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=882774658cb8daee4c16677a3fd674f6052cc157 commit 882774658cb8daee4c16677a3fd674f6052cc157 Author: Joseph Myers Date: Fri Oct 30 21:40:25 2020 +0000 Disable spurious -Warray-bounds for ypclnt.c (bug 26687) Included among the GCC 11 warnings listed in bug 26687, but not fixed when that bug was marked as FIXED, are -Warray-bounds warnings in nis/ypclnt.c. These are all for different calls to the same piece of code, which already has a comment explaining that the element accessed is in a common prefix of the various structures. On the basis of that comment, this patch treats the warning as a false positive and disables it for that code. Tested with build-many-glibcs.py for arm-linux-gnueabi, where, together with my previous two patches, this allows the build of glibc to complete with GCC 11 (further build failures appear in the testsuite). Reviewed-by: DJ Delorie Diff: --- nis/ypclnt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/nis/ypclnt.c b/nis/ypclnt.c index ada08bf982..898f8143e9 100644 --- a/nis/ypclnt.c +++ b/nis/ypclnt.c @@ -30,6 +30,7 @@ #include #include #include +#include /* This should only be defined on systems with a BSD compatible ypbind */ #ifndef BINDINGDIR @@ -368,12 +369,19 @@ do_ypcall_tr (const char *domain, u_long prog, xdrproc_t xargs, caddr_t req, xdrproc_t xres, caddr_t resp) { int status = do_ypcall (domain, prog, xargs, req, xres, resp); + DIAG_PUSH_NEEDS_COMMENT; + /* This cast results in a warning that a ypresp_val is partly + outside the bounds of the actual object referenced, but as + explained below only the stat element (in a common prefix) is + accessed. */ + DIAG_IGNORE_NEEDS_COMMENT (11, "-Warray-bounds"); if (status == YPERR_SUCCESS) /* We cast to ypresp_val although the pointer could also be of type ypresp_key_val or ypresp_master or ypresp_order or ypresp_maplist. But the stat element is in a common prefix so this does not matter. */ status = ypprot_err (((struct ypresp_val *) resp)->stat); + DIAG_POP_NEEDS_COMMENT; return status; }