public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Samuel Thibault <sthibaul@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] bsd unlockpt: unlockpt needs to fail with EINVAL, not ENOTTY Date: Sun, 8 Nov 2020 14:09:57 +0000 (GMT) [thread overview] Message-ID: <20201108140957.C7BF43854820@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=dfe2e7a5627f2c7bdc298fc714dbf12f7666fa2a commit dfe2e7a5627f2c7bdc298fc714dbf12f7666fa2a Author: Samuel Thibault <samuel.thibault@ens-lyon.org> Date: Sun Nov 8 14:06:56 2020 +0000 bsd unlockpt: unlockpt needs to fail with EINVAL, not ENOTTY The EINVAL error code is mandated by POSIX, while ptsname_r returns ENOTTY, so we need to translate. Diff: --- sysdeps/unix/bsd/unlockpt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sysdeps/unix/bsd/unlockpt.c b/sysdeps/unix/bsd/unlockpt.c index d8b7f0cae7..e609685c2f 100644 --- a/sysdeps/unix/bsd/unlockpt.c +++ b/sysdeps/unix/bsd/unlockpt.c @@ -20,6 +20,7 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> +#include <errno.h> /* Unlock the slave pseudo terminal associated with the master pseudo @@ -31,6 +32,10 @@ unlockpt (int fd) /* BSD doesn't have a lock, but it does have `revoke'. */ if (__ptsname_r (fd, buf, sizeof (buf))) - return -1; + { + if (errno == ENOTTY) + __set_errno (EINVAL); + return -1; + } return __revoke (buf); }
reply other threads:[~2020-11-08 14:09 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201108140957.C7BF43854820@sourceware.org \ --to=sthibaul@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).