public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] posix/tst-rfc3484: Fix compile failure linking to local __stat64 Date: Wed, 3 Feb 2021 20:01:59 +0000 (GMT) [thread overview] Message-ID: <20210203200159.C59BE386EC62@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a4efbf44757477717a907078c340386146c7623f commit a4efbf44757477717a907078c340386146c7623f Author: Stafford Horne <shorne@gmail.com> Date: Wed Feb 3 15:36:47 2021 -0300 posix/tst-rfc3484: Fix compile failure linking to local __stat64 After 04986243d1 ("Remove internal usage of extensible stat functions") linking the __stat64 symbol in getaddrinfo for this test fails with the below error: [...] or1k-smh-linux-gnu/bin/ld: [...]/posix/tst-rfc3484.o: in function `gaiconf_reload': [...]/sysdeps/posix/getaddrinfo.c:2136: undefined reference to `__stat64' collect2: error: ld returned 1 exit status This is because __stat64 is a local symbol, the test includes the getaddrinfo directly and fails to link against the local symbol. Fix this by setting up an alias to the global stat64 symbol name like is done for other local symbol usage. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Diff: --- posix/tst-rfc3484-2.c | 1 + posix/tst-rfc3484-3.c | 1 + posix/tst-rfc3484.c | 1 + 3 files changed, 3 insertions(+) diff --git a/posix/tst-rfc3484-2.c b/posix/tst-rfc3484-2.c index 5f5ada9420..ce8ccd5f38 100644 --- a/posix/tst-rfc3484-2.c +++ b/posix/tst-rfc3484-2.c @@ -11,6 +11,7 @@ #define __gethostbyaddr_r gethostbyaddr_r #define __gethostbyname2_r gethostbyname2_r #define __qsort_r qsort_r +#define __stat64 stat64 void attribute_hidden diff --git a/posix/tst-rfc3484-3.c b/posix/tst-rfc3484-3.c index d9ec5cc851..ecb163963f 100644 --- a/posix/tst-rfc3484-3.c +++ b/posix/tst-rfc3484-3.c @@ -11,6 +11,7 @@ #define __gethostbyaddr_r gethostbyaddr_r #define __gethostbyname2_r gethostbyname2_r #define __qsort_r qsort_r +#define __stat64 stat64 void attribute_hidden diff --git a/posix/tst-rfc3484.c b/posix/tst-rfc3484.c index 97d065b6bf..3b2052eb54 100644 --- a/posix/tst-rfc3484.c +++ b/posix/tst-rfc3484.c @@ -11,6 +11,7 @@ #define __gethostbyaddr_r gethostbyaddr_r #define __gethostbyname2_r gethostbyname2_r #define __qsort_r qsort_r +#define __stat64 stat64 void attribute_hidden
reply other threads:[~2021-02-03 20:01 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210203200159.C59BE386EC62@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).