[glibc/nsz/bug19329] elf: Fix comments and logic in _dl_add_to_slotinfo

[glibc/nsz/bug19329] elf: Fix comments and logic in _dl_add_to_slotinfo

[Szabolcs Nagy]

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=068770faf123b7c227f5f1e130812f7976e74cef

commit 068770faf123b7c227f5f1e130812f7976e74cef
Author: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
Date:   Wed Nov 30 11:44:25 2016 +0000

    elf: Fix comments and logic in _dl_add_to_slotinfo
    
    Since
    
      commit a509eb117fac1d764b15eba64993f4bdb63d7f3c
      Avoid late dlopen failure due to scope, TLS slotinfo updates [BZ #25112]
    
    the generation counter update is not needed in the failure path.

Diff:
---
 elf/dl-tls.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/elf/dl-tls.c b/elf/dl-tls.c
index 79b93ad91b..24d00c14ef 100644
--- a/elf/dl-tls.c
+++ b/elf/dl-tls.c
@@ -998,16 +998,7 @@ _dl_add_to_slotinfo (struct link_map *l, bool do_add)
 		+ TLS_SLOTINFO_SURPLUS * sizeof (struct dtv_slotinfo));
       if (listp == NULL)
 	{
-	  /* We ran out of memory.  We will simply fail this
-	     call but don't undo anything we did so far.  The
-	     application will crash or be terminated anyway very
-	     soon.  */
-
-	  /* We have to do this since some entries in the dtv
-	     slotinfo array might already point to this
-	     generation.  */
-	  ++GL(dl_tls_generation);
-
+	  /* We ran out of memory while resizing the dtv slotinfo list.  */
 	  _dl_signal_error (ENOMEM, "dlopen", NULL, N_("\
 cannot create TLS data structures"));
 	}

[glibc/nsz/bug19329] elf: Fix comments and logic in _dl_add_to_slotinfo

[Szabolcs Nagy]

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c54c412fe3313aee772cf1e8e0db11f8547726af

commit c54c412fe3313aee772cf1e8e0db11f8547726af
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Nov 30 11:44:25 2016 +0000

    elf: Fix comments and logic in _dl_add_to_slotinfo
    
    Since
    
      commit a509eb117fac1d764b15eba64993f4bdb63d7f3c
      Avoid late dlopen failure due to scope, TLS slotinfo updates [BZ #25112]
    
    the generation counter update is not needed in the failure path.

Diff:
---
 elf/dl-tls.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/elf/dl-tls.c b/elf/dl-tls.c
index 79b93ad91b..24d00c14ef 100644
--- a/elf/dl-tls.c
+++ b/elf/dl-tls.c
@@ -998,16 +998,7 @@ _dl_add_to_slotinfo (struct link_map *l, bool do_add)
 		+ TLS_SLOTINFO_SURPLUS * sizeof (struct dtv_slotinfo));
       if (listp == NULL)
 	{
-	  /* We ran out of memory.  We will simply fail this
-	     call but don't undo anything we did so far.  The
-	     application will crash or be terminated anyway very
-	     soon.  */
-
-	  /* We have to do this since some entries in the dtv
-	     slotinfo array might already point to this
-	     generation.  */
-	  ++GL(dl_tls_generation);
-
+	  /* We ran out of memory while resizing the dtv slotinfo list.  */
 	  _dl_signal_error (ENOMEM, "dlopen", NULL, N_("\
 cannot create TLS data structures"));
 	}