public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] aarch64: Remove the unused __read_tp symbol
@ 2021-02-22  9:17 Szabolcs Nagy
  0 siblings, 0 replies; only message in thread
From: Szabolcs Nagy @ 2021-02-22  9:17 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=fb37ef69602a1ba635268cd9033a86adc817c53d

commit fb37ef69602a1ba635268cd9033a86adc817c53d
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu Feb 18 10:56:34 2021 +0000

    aarch64: Remove the unused __read_tp symbol
    
    This was likely a mistake in the original aarch64 port copied over
    from arm: on aarch64 tpidr_el0 register is always available.
    
    The __read_tp symbol is visible with static linking, but it's not
    part of the public ABI so it should be safe to remove.

Diff:
---
 sysdeps/unix/sysv/linux/aarch64/Makefile         |  7 -------
 sysdeps/unix/sysv/linux/aarch64/__read_tp.S      | 25 ------------------------
 sysdeps/unix/sysv/linux/aarch64/libc-__read_tp.S | 19 ------------------
 3 files changed, 51 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/aarch64/Makefile b/sysdeps/unix/sysv/linux/aarch64/Makefile
index 4bcae85bca..3f22f71bef 100644
--- a/sysdeps/unix/sysv/linux/aarch64/Makefile
+++ b/sysdeps/unix/sysv/linux/aarch64/Makefile
@@ -1,11 +1,4 @@
-ifeq ($(subdir),csu)
-sysdep_routines      += __read_tp libc-__read_tp
-static-only-routines += __read_tp
-shared-only-routines += libc-__read_tp
-endif
-
 ifeq ($(subdir),elf)
-sysdep-rtld-routines += __read_tp
 ifeq ($(build-shared),yes)
 # This is needed for DSO loading from static binaries.
 sysdep-dl-routines += dl-static
diff --git a/sysdeps/unix/sysv/linux/aarch64/__read_tp.S b/sysdeps/unix/sysv/linux/aarch64/__read_tp.S
deleted file mode 100644
index 3a18d73399..0000000000
--- a/sysdeps/unix/sysv/linux/aarch64/__read_tp.S
+++ /dev/null
@@ -1,25 +0,0 @@
-/* Copyright (C) 2005-2021 Free Software Foundation, Inc.
-
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public License as
-   published by the Free Software Foundation; either version 2.1 of the
-   License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <sysdep.h>
-
-	.hidden __read_tp
-ENTRY (__read_tp)
-	mrs	x0, tpidr_el0
-	RET
-END   (__read_tp)
diff --git a/sysdeps/unix/sysv/linux/aarch64/libc-__read_tp.S b/sysdeps/unix/sysv/linux/aarch64/libc-__read_tp.S
deleted file mode 100644
index c10b1dd356..0000000000
--- a/sysdeps/unix/sysv/linux/aarch64/libc-__read_tp.S
+++ /dev/null
@@ -1,19 +0,0 @@
-/* Copyright (C) 2009-2021 Free Software Foundation, Inc.
-
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public License as
-   published by the Free Software Foundation; either version 2.1 of the
-   License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <__read_tp.S>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-22  9:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22  9:17 [glibc] aarch64: Remove the unused __read_tp symbol Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).