From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 4A263385802A; Fri, 26 Feb 2021 20:42:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A263385802A Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/y2038] tst: Add test for utime X-Act-Checkin: glibc X-Git-Author: Lukasz Majewski X-Git-Refname: refs/heads/azanella/y2038 X-Git-Oldrev: a5b344351312b6e10dda5aa6c33f272100d9e475 X-Git-Newrev: c3876104eeb521cecac095a83a0186be2fae19e2 Message-Id: <20210226204235.4A263385802A@sourceware.org> Date: Fri, 26 Feb 2021 20:42:35 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 20:42:35 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c3876104eeb521cecac095a83a0186be2fae19e2 commit c3876104eeb521cecac095a83a0186be2fae19e2 Author: Lukasz Majewski Date: Fri Feb 26 09:07:45 2021 -0300 tst: Add test for utime This patch provides test for utime. It uses xfstat() syscall to read access and modification times to compare with ones written by utime. Moreover, access and modification times beyond the Y2038 threshold date (i.e. 32 bit time_t overflow) are also checked. Diff: --- sysdeps/unix/sysv/linux/Makefile | 2 +- sysdeps/unix/sysv/linux/tst-utime.c | 83 +++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile index e4345d0b52..ab42a53238 100644 --- a/sysdeps/unix/sysv/linux/Makefile +++ b/sysdeps/unix/sysv/linux/Makefile @@ -107,7 +107,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \ tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \ tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \ - tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime + tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables diff --git a/sysdeps/unix/sysv/linux/tst-utime.c b/sysdeps/unix/sysv/linux/tst-utime.c new file mode 100644 index 0000000000..fe1869702c --- /dev/null +++ b/sysdeps/unix/sysv/linux/tst-utime.c @@ -0,0 +1,83 @@ +/* Test for utime + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include +#include +#include + +static int temp_fd = -1; +char *testfile; + +/* struct utimbuf with Y2038 threshold minus 2 and 1 seconds. */ +const struct utimbuf t1 = { 0x7FFFFFFE, 0x7FFFFFFF }; + +/* struct utimbuf with Y2038 threshold plus 1 and 2 seconds. */ +const struct utimbuf t2 = { 0x80000001ULL, 0x80000002ULL }; + +/* struct utimbuf around Y2038 threshold. */ +const struct utimbuf t3 = { 0x7FFFFFFE, 0x80000002ULL }; + +#define PREPARE do_prepare +static void +do_prepare (int argc, char *argv[]) +{ + temp_fd = create_temp_file ("utime", &testfile); + TEST_VERIFY_EXIT (temp_fd > 0); +} + +static int +test_utime_helper (const struct utimbuf *ut) +{ + struct stat64 st; + int result; + time_t t; + + /* Check if we run on port with 32 bit time_t size */ + if (__builtin_add_overflow (ut->actime, 0, &t)) + return 0; + + result = utime(testfile, ut); + TEST_VERIFY_EXIT (result == 0); + + xfstat (temp_fd, &st); + + /* Check if seconds for actime match */ + TEST_COMPARE (st.st_atime, ut->actime); + + /* Check if seconds for modtime match */ + TEST_COMPARE (st.st_mtime, ut->modtime); + + return 0; +} + +static int +do_test (void) +{ + test_utime_helper (&t1); + test_utime_helper (&t2); + test_utime_helper (&t3); + + return 0; +} + +#include