public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/azanella/y2038] tst: Add test for utimes
@ 2021-03-01 17:36 Adhemerval Zanella
0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2021-03-01 17:36 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=23485b5ea0a800b2c065c0d086877d758b821da6
commit 23485b5ea0a800b2c065c0d086877d758b821da6
Author: Lukasz Majewski <lukma@denx.de>
Date: Fri Feb 26 09:09:55 2021 -0300
tst: Add test for utimes
This patch provides test for utimes. It uses xfstat() syscall to read
access and modification times to compare with ones written by utimes.
Moreover, access and modification times beyond the Y2038 threshold
date (i.e. 32 bit time_t overflow) are also checked.
Diff:
---
sysdeps/unix/sysv/linux/Makefile | 3 +-
sysdeps/unix/sysv/linux/tst-utimes.c | 84 ++++++++++++++++++++++++++++++++++++
2 files changed, 86 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
index ab42a53238..ca587858d8 100644
--- a/sysdeps/unix/sysv/linux/Makefile
+++ b/sysdeps/unix/sysv/linux/Makefile
@@ -107,7 +107,8 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \
test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \
tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \
tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \
- tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime
+ tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime \
+ tst-utimes
tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc
CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables
diff --git a/sysdeps/unix/sysv/linux/tst-utimes.c b/sysdeps/unix/sysv/linux/tst-utimes.c
new file mode 100644
index 0000000000..db43660262
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/tst-utimes.c
@@ -0,0 +1,84 @@
+/* Test for utimes
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <stdlib.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <support/temp_file.h>
+
+static int temp_fd = -1;
+static char *testfile;
+
+/* struct timeval array with Y2038 threshold minus 2 and 1 seconds. */
+const static struct timeval t1[2] = { { 0x7FFFFFFE, 0 }, { 0x7FFFFFFF, 0 } };
+
+/* struct timeval array with Y2038 threshold plus 1 and 2 seconds. */
+const static struct timeval t2[2] = { { 0x80000001ULL, 0 },
+ { 0x80000002ULL, 0 } };
+
+/* struct timeval array around Y2038 threshold. */
+const static struct timeval t3[2] = { { 0x7FFFFFFE, 0 },
+ { 0x80000002ULL, 0 } };
+
+#define PREPARE do_prepare
+static void
+do_prepare (int argc, char *argv[])
+{
+ temp_fd = create_temp_file ("utimes", &testfile);
+ TEST_VERIFY_EXIT (temp_fd > 0);
+}
+
+static int
+test_utime_helper (const struct timeval *tv)
+{
+ struct stat64 st;
+ int result;
+ time_t t;
+
+ /* Check if we run on port with 32 bit time_t size */
+ if (__builtin_add_overflow (tv->tv_sec, 0, &t))
+ return 0;
+
+ result = utimes(testfile, tv);
+ TEST_VERIFY_EXIT (result == 0);
+
+ xfstat (temp_fd, &st);
+
+ /* Check if seconds for atime match */
+ TEST_COMPARE (st.st_atime, tv[0].tv_sec);
+
+ /* Check if seconds for mtime match */
+ TEST_COMPARE (st.st_mtime, tv[1].tv_sec);
+
+ return 0;
+}
+
+static int
+do_test (void)
+{
+ test_utime_helper (&t1[0]);
+ test_utime_helper (&t2[0]);
+ test_utime_helper (&t3[0]);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [glibc/azanella/y2038] tst: Add test for utimes
@ 2021-03-02 12:32 Adhemerval Zanella
0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2021-03-02 12:32 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=56dbd908bce68f9c2a7776a111c6a2f8d7f4f9dc
commit 56dbd908bce68f9c2a7776a111c6a2f8d7f4f9dc
Author: Lukasz Majewski <lukma@denx.de>
Date: Fri Feb 26 09:09:55 2021 -0300
tst: Add test for utimes
This patch provides test for utimes. It uses xfstat() syscall to read
access and modification times to compare with ones written by utimes.
Moreover, access and modification times beyond the Y2038 threshold
date (i.e. 32 bit time_t overflow) are also checked.
Diff:
---
sysdeps/unix/sysv/linux/Makefile | 3 +-
sysdeps/unix/sysv/linux/tst-utimes.c | 84 ++++++++++++++++++++++++++++++++++++
2 files changed, 86 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
index ab42a53238..ca587858d8 100644
--- a/sysdeps/unix/sysv/linux/Makefile
+++ b/sysdeps/unix/sysv/linux/Makefile
@@ -107,7 +107,8 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \
test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \
tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \
tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \
- tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime
+ tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime \
+ tst-utimes
tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc
CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables
diff --git a/sysdeps/unix/sysv/linux/tst-utimes.c b/sysdeps/unix/sysv/linux/tst-utimes.c
new file mode 100644
index 0000000000..db43660262
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/tst-utimes.c
@@ -0,0 +1,84 @@
+/* Test for utimes
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <stdlib.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <support/temp_file.h>
+
+static int temp_fd = -1;
+static char *testfile;
+
+/* struct timeval array with Y2038 threshold minus 2 and 1 seconds. */
+const static struct timeval t1[2] = { { 0x7FFFFFFE, 0 }, { 0x7FFFFFFF, 0 } };
+
+/* struct timeval array with Y2038 threshold plus 1 and 2 seconds. */
+const static struct timeval t2[2] = { { 0x80000001ULL, 0 },
+ { 0x80000002ULL, 0 } };
+
+/* struct timeval array around Y2038 threshold. */
+const static struct timeval t3[2] = { { 0x7FFFFFFE, 0 },
+ { 0x80000002ULL, 0 } };
+
+#define PREPARE do_prepare
+static void
+do_prepare (int argc, char *argv[])
+{
+ temp_fd = create_temp_file ("utimes", &testfile);
+ TEST_VERIFY_EXIT (temp_fd > 0);
+}
+
+static int
+test_utime_helper (const struct timeval *tv)
+{
+ struct stat64 st;
+ int result;
+ time_t t;
+
+ /* Check if we run on port with 32 bit time_t size */
+ if (__builtin_add_overflow (tv->tv_sec, 0, &t))
+ return 0;
+
+ result = utimes(testfile, tv);
+ TEST_VERIFY_EXIT (result == 0);
+
+ xfstat (temp_fd, &st);
+
+ /* Check if seconds for atime match */
+ TEST_COMPARE (st.st_atime, tv[0].tv_sec);
+
+ /* Check if seconds for mtime match */
+ TEST_COMPARE (st.st_mtime, tv[1].tv_sec);
+
+ return 0;
+}
+
+static int
+do_test (void)
+{
+ test_utime_helper (&t1[0]);
+ test_utime_helper (&t2[0]);
+ test_utime_helper (&t3[0]);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [glibc/azanella/y2038] tst: Add test for utimes
@ 2021-02-26 20:42 Adhemerval Zanella
0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2021-02-26 20:42 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=98fea27115bdfbae70608b6a6512f54c4aa10642
commit 98fea27115bdfbae70608b6a6512f54c4aa10642
Author: Lukasz Majewski <lukma@denx.de>
Date: Fri Feb 26 09:09:55 2021 -0300
tst: Add test for utimes
This patch provides test for utimes. It uses xfstat() syscall to read
access and modification times to compare with ones written by utimes.
Moreover, access and modification times beyond the Y2038 threshold
date (i.e. 32 bit time_t overflow) are also checked.
Diff:
---
sysdeps/unix/sysv/linux/Makefile | 3 +-
sysdeps/unix/sysv/linux/tst-utimes.c | 84 ++++++++++++++++++++++++++++++++++++
2 files changed, 86 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
index ab42a53238..ca587858d8 100644
--- a/sysdeps/unix/sysv/linux/Makefile
+++ b/sysdeps/unix/sysv/linux/Makefile
@@ -107,7 +107,8 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \
test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \
tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \
tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \
- tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime
+ tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime \
+ tst-utimes
tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc
CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables
diff --git a/sysdeps/unix/sysv/linux/tst-utimes.c b/sysdeps/unix/sysv/linux/tst-utimes.c
new file mode 100644
index 0000000000..db43660262
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/tst-utimes.c
@@ -0,0 +1,84 @@
+/* Test for utimes
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <stdlib.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <support/temp_file.h>
+
+static int temp_fd = -1;
+static char *testfile;
+
+/* struct timeval array with Y2038 threshold minus 2 and 1 seconds. */
+const static struct timeval t1[2] = { { 0x7FFFFFFE, 0 }, { 0x7FFFFFFF, 0 } };
+
+/* struct timeval array with Y2038 threshold plus 1 and 2 seconds. */
+const static struct timeval t2[2] = { { 0x80000001ULL, 0 },
+ { 0x80000002ULL, 0 } };
+
+/* struct timeval array around Y2038 threshold. */
+const static struct timeval t3[2] = { { 0x7FFFFFFE, 0 },
+ { 0x80000002ULL, 0 } };
+
+#define PREPARE do_prepare
+static void
+do_prepare (int argc, char *argv[])
+{
+ temp_fd = create_temp_file ("utimes", &testfile);
+ TEST_VERIFY_EXIT (temp_fd > 0);
+}
+
+static int
+test_utime_helper (const struct timeval *tv)
+{
+ struct stat64 st;
+ int result;
+ time_t t;
+
+ /* Check if we run on port with 32 bit time_t size */
+ if (__builtin_add_overflow (tv->tv_sec, 0, &t))
+ return 0;
+
+ result = utimes(testfile, tv);
+ TEST_VERIFY_EXIT (result == 0);
+
+ xfstat (temp_fd, &st);
+
+ /* Check if seconds for atime match */
+ TEST_COMPARE (st.st_atime, tv[0].tv_sec);
+
+ /* Check if seconds for mtime match */
+ TEST_COMPARE (st.st_mtime, tv[1].tv_sec);
+
+ return 0;
+}
+
+static int
+do_test (void)
+{
+ test_utime_helper (&t1[0]);
+ test_utime_helper (&t2[0]);
+ test_utime_helper (&t3[0]);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-02 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 17:36 [glibc/azanella/y2038] tst: Add test for utimes Adhemerval Zanella
-- strict thread matches above, loose matches on Subject: below --
2021-03-02 12:32 Adhemerval Zanella
2021-02-26 20:42 Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).