public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/y2038] tst: Add test for utime Date: Tue, 2 Mar 2021 12:32:00 +0000 (GMT) [thread overview] Message-ID: <20210302123200.F35E13947C3B@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8c3645e61378c5f349f531fdb8d306f2459397ac commit 8c3645e61378c5f349f531fdb8d306f2459397ac Author: Lukasz Majewski <lukma@denx.de> Date: Fri Feb 26 09:07:45 2021 -0300 tst: Add test for utime This patch provides test for utime. It uses xfstat() syscall to read access and modification times to compare with ones written by utime. Moreover, access and modification times beyond the Y2038 threshold date (i.e. 32 bit time_t overflow) are also checked. Diff: --- sysdeps/unix/sysv/linux/Makefile | 2 +- sysdeps/unix/sysv/linux/tst-utime.c | 83 +++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile index e4345d0b52..ab42a53238 100644 --- a/sysdeps/unix/sysv/linux/Makefile +++ b/sysdeps/unix/sysv/linux/Makefile @@ -107,7 +107,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \ tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \ tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \ - tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime + tst-timerfd tst-ppoll tst-futimens tst-clock_adjtime tst-utime tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables diff --git a/sysdeps/unix/sysv/linux/tst-utime.c b/sysdeps/unix/sysv/linux/tst-utime.c new file mode 100644 index 0000000000..fe1869702c --- /dev/null +++ b/sysdeps/unix/sysv/linux/tst-utime.c @@ -0,0 +1,83 @@ +/* Test for utime + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <https://www.gnu.org/licenses/>. */ + +#include <time.h> +#include <stdlib.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <utime.h> +#include <support/check.h> +#include <support/xunistd.h> +#include <support/temp_file.h> + +static int temp_fd = -1; +char *testfile; + +/* struct utimbuf with Y2038 threshold minus 2 and 1 seconds. */ +const struct utimbuf t1 = { 0x7FFFFFFE, 0x7FFFFFFF }; + +/* struct utimbuf with Y2038 threshold plus 1 and 2 seconds. */ +const struct utimbuf t2 = { 0x80000001ULL, 0x80000002ULL }; + +/* struct utimbuf around Y2038 threshold. */ +const struct utimbuf t3 = { 0x7FFFFFFE, 0x80000002ULL }; + +#define PREPARE do_prepare +static void +do_prepare (int argc, char *argv[]) +{ + temp_fd = create_temp_file ("utime", &testfile); + TEST_VERIFY_EXIT (temp_fd > 0); +} + +static int +test_utime_helper (const struct utimbuf *ut) +{ + struct stat64 st; + int result; + time_t t; + + /* Check if we run on port with 32 bit time_t size */ + if (__builtin_add_overflow (ut->actime, 0, &t)) + return 0; + + result = utime(testfile, ut); + TEST_VERIFY_EXIT (result == 0); + + xfstat (temp_fd, &st); + + /* Check if seconds for actime match */ + TEST_COMPARE (st.st_atime, ut->actime); + + /* Check if seconds for modtime match */ + TEST_COMPARE (st.st_mtime, ut->modtime); + + return 0; +} + +static int +do_test (void) +{ + test_utime_helper (&t1); + test_utime_helper (&t2); + test_utime_helper (&t3); + + return 0; +} + +#include <support/test-driver.c>
next reply other threads:[~2021-03-02 12:32 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-02 12:32 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2021-03-01 17:36 Adhemerval Zanella 2021-02-26 20:42 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210302123200.F35E13947C3B@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).