public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/nsz/mtag] malloc: Avoid taggig mmaped memory on free
Date: Thu, 11 Mar 2021 17:38:50 +0000 (GMT)	[thread overview]
Message-ID: <20210311173850.4C468384B060@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d9ba54fe178563174ff409481553f67b2e65296e

commit d9ba54fe178563174ff409481553f67b2e65296e
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu Feb 4 11:52:14 2021 +0000

    malloc: Avoid taggig mmaped memory on free
    
    Either the memory belongs to the dumped area, in which case we don't
    want to tag (the dumped area has the same tag as malloc internal data
    so tagging is unnecessary, but chunks there may not have the right
    alignment for the tag granule), or the memory will be unmapped
    immediately (and thus tagging is not useful).
    
    Reviewed-by: DJ Delorie <dj@redhat.com>

Diff:
---
 malloc/malloc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/malloc/malloc.c b/malloc/malloc.c
index 61c25d0f93..ecb87350b0 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -3284,9 +3284,6 @@ __libc_free (void *mem)
 
   p = mem2chunk (mem);
 
-  /* Mark the chunk as belonging to the library again.  */
-  (void)TAG_REGION (chunk2rawmem (p), CHUNK_AVAILABLE_SIZE (p) - CHUNK_HDR_SZ);
-
   if (chunk_is_mmapped (p))                       /* release mmapped memory. */
     {
       /* See if the dynamic brk/mmap threshold needs adjusting.
@@ -3307,6 +3304,10 @@ __libc_free (void *mem)
     {
       MAYBE_INIT_TCACHE ();
 
+      /* Mark the chunk as belonging to the library again.  */
+      (void)TAG_REGION (chunk2rawmem (p),
+			CHUNK_AVAILABLE_SIZE (p) - CHUNK_HDR_SZ);
+
       ar_ptr = arena_for_chunk (p);
       _int_free (ar_ptr, p, 0);
     }


             reply	other threads:[~2021-03-11 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 17:38 Szabolcs Nagy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-19 11:57 Szabolcs Nagy
2021-03-11 17:40 Szabolcs Nagy
2021-03-04 16:25 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311173850.4C468384B060@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).