public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477]
@ 2021-05-07 11:39 H.J. Lu
  0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2021-05-07 11:39 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=69e0a5eb0d5acb4b55dbef68b68fc4a10f2911af

commit 69e0a5eb0d5acb4b55dbef68b68fc4a10f2911af
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Feb 26 13:07:18 2021 -0800

    Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477]
    
    When glibc is configured with --enable-hardcoded-path-in-tests,
    "make xcheck" failed with
    
    ...
    env GCONV_PATH=/export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconvdata LOCPATH=/export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/localedata LC_ALL=C  /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig  --output=$tmp --nostdlib /usr/lib64/gconv;
    ...
    /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig)
    ...
    FAIL: iconv/test-iconvconfig
    
    Since $(objpfx)iconvconfig is an installed program, run it with
    $(run-program-prefix).

Diff:
---
 iconv/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/iconv/Makefile b/iconv/Makefile
index 659857dd8c..a9b267c851 100644
--- a/iconv/Makefile
+++ b/iconv/Makefile
@@ -95,11 +95,12 @@ $(inst_bindir)/iconv: $(objpfx)iconv_prog $(+force)
 $(objpfx)iconv_prog: $(iconv_prog-modules:%=$(objpfx)%.o)
 $(objpfx)iconvconfig: $(iconvconfig-modules:%=$(objpfx)%.o)
 
-$(objpfx)test-iconvconfig.out: /dev/null $(objpfx)iconvconfig
+$(objpfx)test-iconvconfig.out: $(objpfx)iconvconfig
 	(set -e; \
 	 tmp=$(objpfx)gconv-modules.cache.$$$$; \
 	 rm -f $$tmp; \
-	 $(make-test-out) --output=$$tmp --nostdlib $(inst_gconvdir); \
+	 $(run-program-prefix) $(objpfx)iconvconfig \
+		--output=$$tmp --nostdlib $(inst_gconvdir); \
 	 cmp $$tmp $(inst_gconvdir)/gconv-modules.cache; \
 	 rm -f $$tmp) > $@; \
 	$(evaluate-test)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-07 11:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 11:39 [glibc] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477] H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).