public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tulio Magno Quites Machado Filho <tuliom@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] mtrace: Add attribute nocommon to mallwatch
Date: Fri,  2 Jul 2021 21:44:09 +0000 (GMT)	[thread overview]
Message-ID: <20210702214409.764533857C78@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e766ce3088e1da976d6fa7903870683b3fed7f17

commit e766ce3088e1da976d6fa7903870683b3fed7f17
Author: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Date:   Fri Jul 2 18:12:13 2021 -0300

    mtrace: Add attribute nocommon to mallwatch
    
    Avoid compilation errors GCC versions that do not default to
    -fno-common, e.g. GCC <= 9.
    
    Fixes commit 00d28960c5388a582a0485e07629b553c32dde49 ("mtrace:
    Deprecate mallwatch and tr_break").
    
    Suggested-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
    Suggested-by: Florian Weimer <fweimer@redhat.com>

Diff:
---
 malloc/mtrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/malloc/mtrace.c b/malloc/mtrace.c
index 6c2c58b706..f5b8321c6b 100644
--- a/malloc/mtrace.c
+++ b/malloc/mtrace.c
@@ -59,7 +59,7 @@ __libc_lock_define_initialized (static, lock);
    case some applications ended up linking against them but they don't actually
    do anything anymore; not that they did much before anyway.  */
 
-void *mallwatch;
+void *mallwatch __attribute__ ((nocommon));
 compat_symbol (libc, mallwatch, mallwatch, GLIBC_2_0);
 
 void


                 reply	other threads:[~2021-07-02 21:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702214409.764533857C78@sourceware.org \
    --to=tuliom@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).