public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] nss: Fix build error with --disable-nscd
Date: Wed, 14 Jul 2021 09:35:51 +0000 (GMT)	[thread overview]
Message-ID: <20210714093551.933C33889C12@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=135425a1dd50cbe2b9db0628d6c2b36c7889f30b

commit 135425a1dd50cbe2b9db0628d6c2b36c7889f30b
Author: Cooper Qu <cooper.qu@linux.alibaba.com>
Date:   Tue Jul 13 20:50:40 2021 +0800

    nss: Fix build error with --disable-nscd
    
    The error is as follows:
    nss_module.c: In function 'module_load_nss_files':
    nss_module.c:117:7: error: 'is_nscd' undeclared (first use in this function)
      117 |   if (is_nscd)
          |       ^~~~~~~
    nss_module.c:117:7: note: each undeclared identifier is reported only once for each function it appears in
    nss_module.c:119:51: error: 'nscd_init_cb' undeclared (first use in this function); did you mean 'nscd_init'?
      119 |       void (*cb) (size_t, struct traced_file *) = nscd_init_cb;
          |                                                   ^~~~~~~~~~~~
          |                                                   nscd_init

Diff:
---
 nss/nss_module.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/nss/nss_module.c b/nss/nss_module.c
index 7b42c585a4..7ea5ad9887 100644
--- a/nss/nss_module.c
+++ b/nss/nss_module.c
@@ -114,14 +114,16 @@ static const function_name nss_function_name_array[] =
 static bool
 module_load_nss_files (struct nss_module *module)
 {
+#ifdef USE_NSCD
   if (is_nscd)
     {
       void (*cb) (size_t, struct traced_file *) = nscd_init_cb;
-#  ifdef PTR_DEMANGLE
+# ifdef PTR_DEMANGLE
       PTR_DEMANGLE (cb);
-#  endif
+# endif
       _nss_files_init (cb);
     }
+#endif
 
   /* Initialize the function pointers, following the double-checked
      locking idiom.  */


                 reply	other threads:[~2021-07-14  9:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210714093551.933C33889C12@sourceware.org \
    --to=fw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).