From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 609EE3AA9422; Thu, 15 Jul 2021 08:10:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 609EE3AA9422 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] resolv: Remove unnecessary res_isourserver_p call from send_dg X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: adcc572a29169e5b571ab06b1a5bf941985d8fe6 X-Git-Newrev: ee3639e0fe61a3692adf660e04f9e6d56475ff52 Message-Id: <20210715081030.609EE3AA9422@sourceware.org> Date: Thu, 15 Jul 2021 08:10:30 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 08:10:30 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ee3639e0fe61a3692adf660e04f9e6d56475ff52 commit ee3639e0fe61a3692adf660e04f9e6d56475ff52 Author: Florian Weimer Date: Thu Jul 15 08:28:51 2021 +0200 resolv: Remove unnecessary res_isourserver_p call from send_dg As the comment indicates, the check is unnecessary due to the way the UDP socket is set up. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell Diff: --- resolv/res_send.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/resolv/res_send.c b/resolv/res_send.c index 9a3bc5804a..a70f3dec05 100644 --- a/resolv/res_send.c +++ b/resolv/res_send.c @@ -1343,12 +1343,6 @@ send_dg(res_state statp, return close_and_return_error (statp, resplen2); } - /* Paranoia check. Due to the connected UDP socket, - the kernel has already filtered invalid addresses - for us. */ - if (!res_ourserver_p(statp, &from)) - goto wait; - /* Check for the correct header layout and a matching question. */ int matching_query = 0; /* Default to no matching query. */