public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Shu-Chun Weng <scw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/google/grte/v5-2.27/master] More aggressively prevent a buffer from being optimized out
Date: Thu, 15 Jul 2021 19:42:47 +0000 (GMT)	[thread overview]
Message-ID: <20210715194247.88E9E385BF84@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7903140dcc2b36c4eadae7132fb51a4463fd134e

commit 7903140dcc2b36c4eadae7132fb51a4463fd134e
Author: Shu-Chun Weng <scw@google.com>
Date:   Mon May 3 16:12:44 2021 -0700

    More aggressively prevent a buffer from being optimized out
    
    The volatile global variable was first introduced in e86f9654c. I have
    noticed the compiler still optimizing the buffer out on AArch64
    presumably because the assignment is after all other observable
    behaviors so it's still valid to eliminate it.

Diff:
---
 string/tst-xbzero-opt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/string/tst-xbzero-opt.c b/string/tst-xbzero-opt.c
index e9c411b2ef..4f16c4d678 100644
--- a/string/tst-xbzero-opt.c
+++ b/string/tst-xbzero-opt.c
@@ -119,17 +119,17 @@ static void
 setup_no_clear (void)
 {
   unsigned char buf[TEST_BUFFER_SIZE];
-  prepare_test_buffer (buf);
   vol_glob = buf;
+  prepare_test_buffer (buf);
 }
 
 static void
 setup_ordinary_clear (void)
 {
   unsigned char buf[TEST_BUFFER_SIZE];
+  vol_glob = buf;
   prepare_test_buffer (buf);
   memset (buf, 0, TEST_BUFFER_SIZE);
-  vol_glob = buf;
 }
 
 static void


             reply	other threads:[~2021-07-15 19:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 19:42 Shu-Chun Weng [this message]
2021-08-28  0:38 Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210715194247.88E9E385BF84@sourceware.org \
    --to=scw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).