public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/siddhesh/malloc-hooks] Make mcheck tests conditional on GLIBC_2.23 or earlier
Date: Mon, 19 Jul 2021 13:29:24 +0000 (GMT)	[thread overview]
Message-ID: <20210719132924.E64CD395180D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=be25071ce74b1805c9855a7d41f3f850ac95342a

commit be25071ce74b1805c9855a7d41f3f850ac95342a
Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
Date:   Fri Jul 9 16:45:08 2021 +0530

    Make mcheck tests conditional on GLIBC_2.23 or earlier
    
    Targets with base versions of 2.24 or later won't have
    __malloc_initialize_hook because of which the tests will essentially
    be the same as the regular malloc tests.  Avoid running them instead
    and save time.

Diff:
---
 malloc/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/malloc/Makefile b/malloc/Makefile
index 47369b6084..6cac2e5d8d 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -78,6 +78,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \
 # Run all tests with MALLOC_CHECK_=3
 tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests))
 
+# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24.
+ifeq ($(have-GLIBC_2.23)$(build-shared),yesyes)
 # Tests that don't play well with mcheck.  They are either bugs in mcheck or
 # the tests expect specific internal behavior that is changed due to linking to
 # libmcheck.a.
@@ -100,6 +102,7 @@ tests-exclude-mcheck = tst-mallocstate \
 	tst-reallocarray
 
 tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
+endif
 
 routines = malloc morecore mcheck mtrace obstack reallocarray \
   scratch_buffer_dupfree \


             reply	other threads:[~2021-07-19 13:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 13:29 Siddhesh Poyarekar [this message]
2021-07-19 17:47 Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210719132924.E64CD395180D@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).