public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] Exclude static tests for mcheck and malloc-check Date: Mon, 26 Jul 2021 05:19:13 +0000 (GMT) [thread overview] Message-ID: <20210726051913.472113864805@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ddcc612ce923038b867083a0c55d6e034951155a commit ddcc612ce923038b867083a0c55d6e034951155a Author: Siddhesh Poyarekar <siddhesh@sourceware.org> Date: Mon Jul 26 10:47:46 2021 +0530 Exclude static tests for mcheck and malloc-check mcheck and malloc-check no longer work with static binaries, so drop those tests. Reported-by: Samuel Thibault <samuel.thibault@gnu.org> Tested-by: Samuel Thibault <samuel.thibault@gnu.org> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Diff: --- malloc/Makefile | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/malloc/Makefile b/malloc/Makefile index d54285192a..9b70831d38 100644 --- a/malloc/Makefile +++ b/malloc/Makefile @@ -75,7 +75,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \ tst-compathooks-off tst-compathooks-on # Run all tests with MALLOC_CHECK_=3 -tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests)) +tests-malloc-check = $(filter-out $(tests-exclude-malloc-check) \ + $(tests-static),$(tests)) # -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24. ifeq ($(have-GLIBC_2.23)$(build-shared),yesyes) @@ -94,7 +95,7 @@ tests-exclude-mcheck = tst-mallocstate \ tst-malloc_info \ tst-compathooks-off tst-compathooks-on -tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests)) +tests-mcheck = $(filter-out $(tests-exclude-mcheck) $(tests-static), $(tests)) endif routines = malloc mcheck mtrace obstack reallocarray \ @@ -290,16 +291,8 @@ $(objpfx)tst-interpose-thread-mcheck: \ $(objpfx)tst-interpose-thread-malloc-check: \ $(objpfx)tst-interpose-aux-thread.o $(shared-thread-library) $(objpfx)tst-interpose-static-nothread: $(objpfx)tst-interpose-aux-nothread.o -$(objpfx)tst-interpose-static-nothread-mcheck: \ - $(objpfx)tst-interpose-aux-nothread.o -$(objpfx)tst-interpose-static-nothread-malloc-check: \ - $(objpfx)tst-interpose-aux-nothread.o $(objpfx)tst-interpose-static-thread: \ $(objpfx)tst-interpose-aux-thread.o $(static-thread-library) -$(objpfx)tst-interpose-static-thread-mcheck: \ - $(objpfx)tst-interpose-aux-thread.o $(static-thread-library) -$(objpfx)tst-interpose-static-thread-malloc-check: \ - $(objpfx)tst-interpose-aux-thread.o $(static-thread-library) tst-dynarray-ENV = MALLOC_TRACE=$(objpfx)tst-dynarray.mtrace \ LD_PRELOAD=$(objpfx)libc_malloc_debug.so
reply other threads:[~2021-07-26 5:19 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210726051913.472113864805@sourceware.org \ --to=siddhesh@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).