From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2206) id 2ECAB3853C1C; Wed, 28 Jul 2021 10:38:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2ECAB3853C1C Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Siddhesh Poyarekar To: glibc-cvs@sourceware.org Subject: [glibc] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] X-Act-Checkin: glibc X-Git-Author: Siddhesh Poyarekar X-Git-Refname: refs/heads/master X-Git-Oldrev: fb1621a88665ade96e7874046ed62b1cd2e7ff35 X-Git-Newrev: 4aedc25f55eda50010f2932fdb0a533db6f89f61 Message-Id: <20210728103828.2ECAB3853C1C@sourceware.org> Date: Wed, 28 Jul 2021 10:38:28 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 10:38:28 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4aedc25f55eda50010f2932fdb0a533db6f89f61 commit 4aedc25f55eda50010f2932fdb0a533db6f89f61 Author: Siddhesh Poyarekar Date: Wed Jul 28 13:11:20 2021 +0530 __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] Abort in the unlikely event that allocation fails when trying to register a TLS destructor. Reviewed-by: Florian Weimer Diff: --- stdlib/cxa_thread_atexit_impl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/stdlib/cxa_thread_atexit_impl.c b/stdlib/cxa_thread_atexit_impl.c index 577ed30931..fa6901a3a6 100644 --- a/stdlib/cxa_thread_atexit_impl.c +++ b/stdlib/cxa_thread_atexit_impl.c @@ -72,6 +72,7 @@ is not very different from a case where __call_tls_dtors is called after _dl_close_worker on the DSO and hence is an accepted execution. */ +#include #include #include @@ -104,6 +105,9 @@ __cxa_thread_atexit_impl (dtor_func func, void *obj, void *dso_symbol) /* Prepend. */ struct dtor_list *new = calloc (1, sizeof (struct dtor_list)); + if (__glibc_unlikely (new == NULL)) + __libc_fatal ("Fatal glibc error: failed to register TLS destructor: " + "out of memory\n"); new->func = func; new->obj = obj; new->next = tls_dtor_list;