From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2206) id 7D1E7395C03A; Tue, 3 Aug 2021 15:55:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D1E7395C03A Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Siddhesh Poyarekar To: glibc-cvs@sourceware.org Subject: [glibc] copy_and_spawn_sgid: Avoid double calls to close() X-Act-Checkin: glibc X-Git-Author: Siddhesh Poyarekar X-Git-Refname: refs/heads/master X-Git-Oldrev: 1e0e6d656db9dfa12ef7eb67976385d3deb0d4ff X-Git-Newrev: 45caed9d67a00af917d8b5b88d4b5eb1225b7aef Message-Id: <20210803155536.7D1E7395C03A@sourceware.org> Date: Tue, 3 Aug 2021 15:55:36 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 15:55:36 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=45caed9d67a00af917d8b5b88d4b5eb1225b7aef commit 45caed9d67a00af917d8b5b88d4b5eb1225b7aef Author: Siddhesh Poyarekar Date: Tue Aug 3 21:10:53 2021 +0530 copy_and_spawn_sgid: Avoid double calls to close() If close() on infd and outfd succeeded, reset the fd numbers so that we don't attempt to close them again. Reviewed-by: Arjun Shankar Diff: --- support/support_capture_subprocess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/support/support_capture_subprocess.c b/support/support_capture_subprocess.c index 27bfd19c93..0bacf6dbc2 100644 --- a/support/support_capture_subprocess.c +++ b/support/support_capture_subprocess.c @@ -170,6 +170,7 @@ copy_and_spawn_sgid (char *child_id, gid_t gid) support_subprogram because we only want the program exit status, not the contents. */ ret = 0; + infd = outfd = -1; char * const args[] = {execname, child_id, NULL};