public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/release/2.34/master] gaiconf_init: Avoid double-free in label and precedence lists Date: Wed, 4 Aug 2021 10:27:17 +0000 (GMT) [thread overview] Message-ID: <20210804102717.C8C7E393C854@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a5bd2e10e0c25b80286dc36068e22a4cb4893af0 commit a5bd2e10e0c25b80286dc36068e22a4cb4893af0 Author: Siddhesh Poyarekar <siddhesh@sourceware.org> Date: Tue Aug 3 21:11:03 2021 +0530 gaiconf_init: Avoid double-free in label and precedence lists labellist and precedencelist could get freed a second time if there are allocation failures, so set them to NULL to avoid a double-free. Reviewed-by: Arjun Shankar <arjun@redhat.com> (cherry picked from commit 77a34079d8f3d63b61543bf3af93043f8674e4c4) Diff: --- sysdeps/posix/getaddrinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c index 838a68f022..43dfc6739e 100644 --- a/sysdeps/posix/getaddrinfo.c +++ b/sysdeps/posix/getaddrinfo.c @@ -2008,6 +2008,7 @@ gaiconf_init (void) l = l->next; } free_prefixlist (labellist); + labellist = NULL; /* Sort the entries so that the most specific ones are at the beginning. */ @@ -2046,6 +2047,7 @@ gaiconf_init (void) l = l->next; } free_prefixlist (precedencelist); + precedencelist = NULL; /* Sort the entries so that the most specific ones are at the beginning. */
reply other threads:[~2021-08-04 10:27 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210804102717.C8C7E393C854@sourceware.org \ --to=siddhesh@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).