public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/release/2.34/master] copy_and_spawn_sgid: Avoid double calls to close() Date: Wed, 4 Aug 2021 10:27:22 +0000 (GMT) [thread overview] Message-ID: <20210804102722.E74E53898537@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7ff4da3dc26de351a5abe7c2905038cbe55c8041 commit 7ff4da3dc26de351a5abe7c2905038cbe55c8041 Author: Siddhesh Poyarekar <siddhesh@sourceware.org> Date: Tue Aug 3 21:10:53 2021 +0530 copy_and_spawn_sgid: Avoid double calls to close() If close() on infd and outfd succeeded, reset the fd numbers so that we don't attempt to close them again. Reviewed-by: Arjun Shankar <arjun@redhat.com> (cherry picked from commit 45caed9d67a00af917d8b5b88d4b5eb1225b7aef) Diff: --- support/support_capture_subprocess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/support/support_capture_subprocess.c b/support/support_capture_subprocess.c index 27bfd19c93..0bacf6dbc2 100644 --- a/support/support_capture_subprocess.c +++ b/support/support_capture_subprocess.c @@ -170,6 +170,7 @@ copy_and_spawn_sgid (char *child_id, gid_t gid) support_subprogram because we only want the program exit status, not the contents. */ ret = 0; + infd = outfd = -1; char * const args[] = {execname, child_id, NULL};
reply other threads:[~2021-08-04 10:27 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210804102722.E74E53898537@sourceware.org \ --to=siddhesh@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).