From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7814) id F140A3951CBF; Mon, 16 Aug 2021 17:15:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F140A3951CBF Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Fangrui Song To: glibc-cvs@sourceware.org Subject: [glibc/maskray/lld] mips: increase stack alignment in clone to match the ABI X-Act-Checkin: glibc X-Git-Author: Xi Ruoyao X-Git-Refname: refs/heads/maskray/lld X-Git-Oldrev: 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe X-Git-Newrev: 0f62fe053273ff6c62ac95c59b7687c964737b00 Message-Id: <20210816171514.F140A3951CBF@sourceware.org> Date: Mon, 16 Aug 2021 17:15:14 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2021 17:15:15 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0f62fe053273ff6c62ac95c59b7687c964737b00 commit 0f62fe053273ff6c62ac95c59b7687c964737b00 Author: Xi Ruoyao Date: Fri Aug 13 16:01:14 2021 +0000 mips: increase stack alignment in clone to match the ABI In "mips: align stack in clone [BZ #28223]" (commit 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe) I made a mistake: I misbelieved one "word" was 2-byte and "doubleword" should be 4-byte. But in MIPS ABI one "word" is defined 32-bit (4-byte), so "doubleword" is 8-byte [1], and "quadword" is 16-byte [2]. [1]: "System V Application Binary Interface: MIPS(R) RISC Processor Supplement, 3rd edition", page 3-31 [2]: "MIPSpro(TM) 64-Bit Porting and Transition Guide", page 23 Diff: --- sysdeps/unix/sysv/linux/mips/clone.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/unix/sysv/linux/mips/clone.S b/sysdeps/unix/sysv/linux/mips/clone.S index 43a5ad3a40..fd71b5ca2e 100644 --- a/sysdeps/unix/sysv/linux/mips/clone.S +++ b/sysdeps/unix/sysv/linux/mips/clone.S @@ -55,11 +55,11 @@ NESTED(__clone,4*SZREG,sp) .set at #endif - /* Align stack to 4/8 bytes per the ABI. */ + /* Align stack to 8/16 bytes per the ABI. */ #if _MIPS_SIM == _ABIO32 - li t0,-4 -#else li t0,-8 +#else + li t0,-16 #endif and a1,a1,t0