From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7814) id 21E2C395200F; Tue, 17 Aug 2021 17:49:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21E2C395200F Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Fangrui Song To: glibc-cvs@sourceware.org Subject: [glibc] x86_64: Simplify elf_machine_{load_address,dynamic} X-Act-Checkin: glibc X-Git-Author: Fangrui Song X-Git-Refname: refs/heads/master X-Git-Oldrev: 33c50ef42878b07ee6ead8b3f1a81d8c2c74697c X-Git-Newrev: b37b75d269883a2c553bb7019a813094eb4e2dd1 Message-Id: <20210817174926.21E2C395200F@sourceware.org> Date: Tue, 17 Aug 2021 17:49:26 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2021 17:49:26 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b37b75d269883a2c553bb7019a813094eb4e2dd1 commit b37b75d269883a2c553bb7019a813094eb4e2dd1 Author: Fangrui Song Date: Tue Aug 17 10:45:57 2021 -0700 x86_64: Simplify elf_machine_{load_address,dynamic} and drop reliance on _GLOBAL_OFFSET_TABLE_[0] being the link-time address of _DYNAMIC. &__ehdr_start is a better way to get the load address. Reviewed-by: H.J. Lu Diff: --- sysdeps/x86_64/dl-machine.h | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h index a8596aa3fa..ceee50734e 100644 --- a/sysdeps/x86_64/dl-machine.h +++ b/sysdeps/x86_64/dl-machine.h @@ -35,27 +35,20 @@ elf_machine_matches_host (const ElfW(Ehdr) *ehdr) } -/* Return the link-time address of _DYNAMIC. Conveniently, this is the - first element of the GOT. This must be inlined in a function which - uses global data. */ +/* Return the run-time load address of the shared object. */ static inline ElfW(Addr) __attribute__ ((unused)) -elf_machine_dynamic (void) +elf_machine_load_address (void) { - /* This produces an IP-relative reloc which is resolved at link time. */ - extern const ElfW(Addr) _GLOBAL_OFFSET_TABLE_[] attribute_hidden; - return _GLOBAL_OFFSET_TABLE_[0]; + extern const ElfW(Ehdr) __ehdr_start attribute_hidden; + return (ElfW(Addr)) &__ehdr_start; } - -/* Return the run-time load address of the shared object. */ +/* Return the link-time address of _DYNAMIC. */ static inline ElfW(Addr) __attribute__ ((unused)) -elf_machine_load_address (void) +elf_machine_dynamic (void) { - /* Compute the difference between the runtime address of _DYNAMIC as seen - by an IP-relative reference, and the link-time address found in the - special unrelocated first GOT entry. */ extern ElfW(Dyn) _DYNAMIC[] attribute_hidden; - return (ElfW(Addr)) &_DYNAMIC - elf_machine_dynamic (); + return (ElfW(Addr)) _DYNAMIC - elf_machine_load_address (); } /* Set up the loaded object described by L so its unrelocated PLT