public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Fangrui Song <maskray@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/google/grte/v5-2.27/master] wordexp: handle overflow in positional parameter number (bug 28011) Date: Sat, 28 Aug 2021 00:40:20 +0000 (GMT) [thread overview] Message-ID: <20210828004020.61E433858038@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6056776143dbc9cb0b62fc3c0f1ce5f44bbb3a71 commit 6056776143dbc9cb0b62fc3c0f1ce5f44bbb3a71 Author: Andreas Schwab <schwab@linux-m68k.org> Date: Fri Jun 25 15:02:47 2021 +0200 wordexp: handle overflow in positional parameter number (bug 28011) Use strtoul instead of atoi so that overflow can be detected. Diff: --- posix/wordexp-test.c | 1 + posix/wordexp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/posix/wordexp-test.c b/posix/wordexp-test.c index cc29840355..30c1dd65ef 100644 --- a/posix/wordexp-test.c +++ b/posix/wordexp-test.c @@ -200,6 +200,7 @@ struct test_case_struct { 0, NULL, "$var", 0, 0, { NULL, }, IFS }, { 0, NULL, "\"\\n\"", 0, 1, { "\\n", }, IFS }, { 0, NULL, "", 0, 0, { NULL, }, IFS }, + { 0, NULL, "${1234567890123456789012}", 0, 0, { NULL, }, IFS }, /* Flags not already covered (testit() has special handling for these) */ { 0, NULL, "one two", WRDE_DOOFFS, 2, { "one", "two", }, IFS }, diff --git a/posix/wordexp.c b/posix/wordexp.c index 8e33ad95b0..b13b0d4b20 100644 --- a/posix/wordexp.c +++ b/posix/wordexp.c @@ -1407,7 +1407,7 @@ envsubst: /* Is it a numeric parameter? */ else if (isdigit (env[0])) { - int n = atoi (env); + unsigned long n = strtoul (env, NULL, 10); if (n >= __libc_argc) /* Substitute NULL. */
next reply other threads:[~2021-08-28 0:40 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-28 0:40 Fangrui Song [this message] -- strict thread matches above, loose matches on Subject: below -- 2021-07-23 17:26 Stan Shebs
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210828004020.61E433858038@sourceware.org \ --to=maskray@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).