public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Fangrui Song <maskray@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/maskray/unnest] Revert "AArch64: Update A64FX memset not to degrade at 16KB"
Date: Thu, 23 Sep 2021 00:43:43 +0000 (GMT)	[thread overview]
Message-ID: <20210923004343.1E75B385843E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f873adf3df443f8d302677f963adcc3c22187e68

commit f873adf3df443f8d302677f963adcc3c22187e68
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Mon Sep 6 10:21:07 2021 +0100

    Revert "AArch64: Update A64FX memset not to degrade at 16KB"
    
    Because of wrong commit author. Will recommit it with right author.
    
    This reverts commit 23777232c23f80809613bdfa329f63aadf992922.

Diff:
---
 sysdeps/aarch64/multiarch/memset_a64fx.S | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
index f7dfdaace7..7bf759b6a7 100644
--- a/sysdeps/aarch64/multiarch/memset_a64fx.S
+++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
@@ -96,14 +96,7 @@ L(vl_agnostic): // VL Agnostic
 L(unroll8):
 	sub	count, count, tmp1
 	.p2align 4
-	// The 2 instructions at the beginning of the following loop,
-	// cmp and branch, are a workaround so as not to degrade at
-	// the peak performance 16KB.
-	// It is found heuristically and the branch condition, b.ne,
-	// is chosen intentionally never to jump.
-1:	cmp	xzr, xzr
-	b.ne	1b
-	st1b_unroll 0, 7
+1:	st1b_unroll 0, 7
 	add	dst, dst, tmp1
 	subs	count, count, tmp1
 	b.hi	1b


                 reply	other threads:[~2021-09-23  0:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923004343.1E75B385843E@sourceware.org \
    --to=maskray@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).