From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7814) id 4B248385801E; Fri, 24 Sep 2021 20:12:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B248385801E Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Fangrui Song To: glibc-cvs@sourceware.org Subject: [glibc/maskray/unnest] Linux: Avoid closing -1 on failure in __closefrom_fallback X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/maskray/unnest X-Git-Oldrev: 91e92272caefad4b6156572fc41671dcbd93afe5 X-Git-Newrev: 5ad9d62c3b7438c70452d6a9b2c7810f9f28bf32 Message-Id: <20210924201236.4B248385801E@sourceware.org> Date: Fri, 24 Sep 2021 20:12:36 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2021 20:12:36 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5ad9d62c3b7438c70452d6a9b2c7810f9f28bf32 commit 5ad9d62c3b7438c70452d6a9b2c7810f9f28bf32 Author: Florian Weimer Date: Fri Sep 24 19:51:41 2021 +0200 Linux: Avoid closing -1 on failure in __closefrom_fallback Reviewed-by: H.J. Lu Diff: --- sysdeps/unix/sysv/linux/closefrom_fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/closefrom_fallback.c b/sysdeps/unix/sysv/linux/closefrom_fallback.c index 9cca55653a..f215fd2c09 100644 --- a/sysdeps/unix/sysv/linux/closefrom_fallback.c +++ b/sysdeps/unix/sysv/linux/closefrom_fallback.c @@ -48,7 +48,7 @@ __closefrom_fallback (int from, _Bool dirfd_fallback) dirfd = __open_nocancel (FD_TO_FILENAME_PREFIX, O_RDONLY | O_DIRECTORY, 0); if (dirfd == -1) - goto err; + return false; } char buffer[1024];