public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/maskray/clang] glibcextract.py: Place un-assemblable @@@ in a comment
@ 2021-10-08  1:44 Fangrui Song
  0 siblings, 0 replies; 4+ messages in thread
From: Fangrui Song @ 2021-10-08  1:44 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=04c3e128158f4a811804a54a1f0e6c4ec0443b59

commit 04c3e128158f4a811804a54a1f0e6c4ec0443b59
Author: Fangrui Song <maskray@google.com>
Date:   Sun Aug 22 22:26:04 2021 -0700

    glibcextract.py: Place un-assemblable @@@ in a comment
    
    Unlike GCC, Clang passes asm statements and verifies they are valid
    instructions/directives. Place the magic @@@ into a comment to avoid
    parse error.

Diff:
---
 scripts/glibcextract.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
index 752ff6223b..bf49a5e322 100644
--- a/scripts/glibcextract.py
+++ b/scripts/glibcextract.py
@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
             continue
         name = arg[0]
         value = arg[1]
-        out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
+        out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
                          ': : \"i\" ((long int) (%s)));'
                          % (name, value))
     out_lines.append('}')


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [glibc/maskray/clang] glibcextract.py: Place un-assemblable @@@ in a comment
@ 2021-10-19 17:01 Fangrui Song
  0 siblings, 0 replies; 4+ messages in thread
From: Fangrui Song @ 2021-10-19 17:01 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=46baeb61e16511f26db1b255e19dc9163f590367

commit 46baeb61e16511f26db1b255e19dc9163f590367
Author: Fangrui Song <maskray@google.com>
Date:   Tue Oct 19 09:58:16 2021 -0700

    glibcextract.py: Place un-assemblable @@@ in a comment
    
    Unlike GCC, Clang parses asm statements and verifies they are valid
    instructions/directives. Place the magic @@@ into a comment to avoid
    a parse error.

Diff:
---
 scripts/glibcextract.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
index 752ff6223b..bf49a5e322 100644
--- a/scripts/glibcextract.py
+++ b/scripts/glibcextract.py
@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
             continue
         name = arg[0]
         value = arg[1]
-        out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
+        out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
                          ': : \"i\" ((long int) (%s)));'
                          % (name, value))
     out_lines.append('}')


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [glibc/maskray/clang] glibcextract.py: Place un-assemblable @@@ in a comment
@ 2021-10-11 18:16 Fangrui Song
  0 siblings, 0 replies; 4+ messages in thread
From: Fangrui Song @ 2021-10-11 18:16 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=917d7ccb4c52505874a7d41ba542214f9d248022

commit 917d7ccb4c52505874a7d41ba542214f9d248022
Author: Fangrui Song <maskray@google.com>
Date:   Sun Aug 22 22:26:04 2021 -0700

    glibcextract.py: Place un-assemblable @@@ in a comment
    
    Unlike GCC, Clang passes asm statements and verifies they are valid
    instructions/directives. Place the magic @@@ into a comment to avoid
    parse error.

Diff:
---
 scripts/glibcextract.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
index 752ff6223b..bf49a5e322 100644
--- a/scripts/glibcextract.py
+++ b/scripts/glibcextract.py
@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
             continue
         name = arg[0]
         value = arg[1]
-        out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
+        out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
                          ': : \"i\" ((long int) (%s)));'
                          % (name, value))
     out_lines.append('}')


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [glibc/maskray/clang] glibcextract.py: Place un-assemblable @@@ in a comment
@ 2021-10-10 23:12 Fangrui Song
  0 siblings, 0 replies; 4+ messages in thread
From: Fangrui Song @ 2021-10-10 23:12 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=addcb9fdb1afebd66a6f3e845ad6fcac00e05fe6

commit addcb9fdb1afebd66a6f3e845ad6fcac00e05fe6
Author: Fangrui Song <maskray@google.com>
Date:   Sun Aug 22 22:26:04 2021 -0700

    glibcextract.py: Place un-assemblable @@@ in a comment
    
    Unlike GCC, Clang passes asm statements and verifies they are valid
    instructions/directives. Place the magic @@@ into a comment to avoid
    parse error.

Diff:
---
 scripts/glibcextract.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
index 752ff6223b..bf49a5e322 100644
--- a/scripts/glibcextract.py
+++ b/scripts/glibcextract.py
@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
             continue
         name = arg[0]
         value = arg[1]
-        out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
+        out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
                          ': : \"i\" ((long int) (%s)));'
                          % (name, value))
     out_lines.append('}')


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-19 17:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08  1:44 [glibc/maskray/clang] glibcextract.py: Place un-assemblable @@@ in a comment Fangrui Song
2021-10-10 23:12 Fangrui Song
2021-10-11 18:16 Fangrui Song
2021-10-19 17:01 Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).