public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Fangrui Song <maskray@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/maskray/clang] glibcextract.py: Place un-assemblable @@@ in a comment
Date: Mon, 11 Oct 2021 18:16:08 +0000 (GMT) [thread overview]
Message-ID: <20211011181608.50A39385842D@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=917d7ccb4c52505874a7d41ba542214f9d248022
commit 917d7ccb4c52505874a7d41ba542214f9d248022
Author: Fangrui Song <maskray@google.com>
Date: Sun Aug 22 22:26:04 2021 -0700
glibcextract.py: Place un-assemblable @@@ in a comment
Unlike GCC, Clang passes asm statements and verifies they are valid
instructions/directives. Place the magic @@@ into a comment to avoid
parse error.
Diff:
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/glibcextract.py b/scripts/glibcextract.py
index 752ff6223b..bf49a5e322 100644
--- a/scripts/glibcextract.py
+++ b/scripts/glibcextract.py
@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
continue
name = arg[0]
value = arg[1]
- out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
+ out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
': : \"i\" ((long int) (%s)));'
% (name, value))
out_lines.append('}')
next reply other threads:[~2021-10-11 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 18:16 Fangrui Song [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-19 17:01 Fangrui Song
2021-10-10 23:12 Fangrui Song
2021-10-08 1:44 Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011181608.50A39385842D@sourceware.org \
--to=maskray@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).