public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Fangrui Song <maskray@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
Date: Mon, 11 Oct 2021 18:16:18 +0000 (GMT)	[thread overview]
Message-ID: <20211011181618.7335F3858409@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c71bbcb392fa59f32a45c3fdfc342620486e3041

commit c71bbcb392fa59f32a45c3fdfc342620486e3041
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


             reply	other threads:[~2021-10-11 18:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 18:16 Fangrui Song [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-03  7:41 Fangrui Song
2021-11-02 20:00 Fangrui Song
2021-10-20 21:24 Fangrui Song
2021-10-19 17:02 Fangrui Song
2021-10-10 23:12 Fangrui Song
2021-10-08  1:44 Fangrui Song
2021-10-07 20:13 Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011181618.7335F3858409@sourceware.org \
    --to=maskray@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).