public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] tst-tzset: output reason when creating 4GiB file fails
@ 2021-11-12 23:09 Stafford Horne
0 siblings, 0 replies; only message in thread
From: Stafford Horne @ 2021-11-12 23:09 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=afbf26492a5adccc4c4eda00eb588b0b79e4290a
commit afbf26492a5adccc4c4eda00eb588b0b79e4290a
Author: Stafford Horne <shorne@gmail.com>
Date: Mon Sep 20 06:03:07 2021 +0900
tst-tzset: output reason when creating 4GiB file fails
Currently, if the temporary file creation fails the create_tz_file
function returns NULL. The NULL pointer is then passed to setenv which
causes a SIGSEGV. Rather than failing with a SIGSEGV print a warning
and exit.
Diff:
---
timezone/tst-tzset.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
index d6da2932bb..3dad42e041 100644
--- a/timezone/tst-tzset.c
+++ b/timezone/tst-tzset.c
@@ -25,6 +25,7 @@
#include <time.h>
#include <unistd.h>
#include <support/check.h>
+#include <inttypes.h>
static int do_test (void);
#define TEST_FUNCTION do_test ()
@@ -103,6 +104,13 @@ static void
test_tz_file (off64_t size)
{
char *path = create_tz_file (size);
+ if (path == NULL)
+ {
+ printf ("creating timezone file of size: %" PRId64 "MiB failed.\n",
+ size / (1024 * 1024));
+ exit (1);
+ }
+
if (setenv ("TZ", path, 1) < 0)
{
printf ("setenv failed: %m\n");
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-12 23:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 23:09 [glibc] tst-tzset: output reason when creating 4GiB file fails Stafford Horne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).