public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/google/grte/v5-2.27/master] Use libc_hidden_* for atoi (bug 15105).
@ 2021-11-15 22:40 Fangrui Song
0 siblings, 0 replies; 2+ messages in thread
From: Fangrui Song @ 2021-11-15 22:40 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2989090595945361a67de72545d43fee9c61eb15
commit 2989090595945361a67de72545d43fee9c61eb15
Author: Joseph Myers <joseph@codesourcery.com>
Date: Mon Feb 26 18:17:47 2018 +0000
Use libc_hidden_* for atoi (bug 15105).
Continuing the fixes for localplt test failures with -Os arising from
functions not being inlined in that case, this patch fixes such
failures for atoi by using libc_hidden_proto and libc_hidden_def.
Tested for x86_64 (both that it removes this particular localplt
failure for -Os, and that the testsuite continues to pass without
-Os).
[BZ #15105]
* stdlib/atoi.c (atoi): Use libc_hidden_def.
* include/stdlib.h [!_ISOMAC] (atoi): Use libc_hidden_proto.
(cherry picked from commit 20602c72fa54bc0923314820ec8148186096bf3b)
Diff:
---
include/stdlib.h | 2 ++
stdlib/atoi.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/stdlib.h b/include/stdlib.h
index 5974fb3d24..114e12d255 100644
--- a/include/stdlib.h
+++ b/include/stdlib.h
@@ -210,6 +210,8 @@ libc_hidden_proto (strtoll)
libc_hidden_proto (strtoul)
libc_hidden_proto (strtoull)
+libc_hidden_proto (atoi)
+
extern float __strtof_nan (const char *, char **, char);
extern double __strtod_nan (const char *, char **, char);
extern long double __strtold_nan (const char *, char **, char);
diff --git a/stdlib/atoi.c b/stdlib/atoi.c
index a6c3f1d547..c42858494f 100644
--- a/stdlib/atoi.c
+++ b/stdlib/atoi.c
@@ -26,3 +26,4 @@ atoi (const char *nptr)
{
return (int) strtol (nptr, (char **) NULL, 10);
}
+libc_hidden_def (atoi)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [glibc/google/grte/v5-2.27/master] Use libc_hidden_* for atoi (bug 15105).
@ 2021-11-19 21:22 Fangrui Song
0 siblings, 0 replies; 2+ messages in thread
From: Fangrui Song @ 2021-11-19 21:22 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c0a436544259c7aef8871c29731a48dc715039db
commit c0a436544259c7aef8871c29731a48dc715039db
Author: Joseph Myers <joseph@codesourcery.com>
Date: Mon Feb 26 18:17:47 2018 +0000
Use libc_hidden_* for atoi (bug 15105).
Continuing the fixes for localplt test failures with -Os arising from
functions not being inlined in that case, this patch fixes such
failures for atoi by using libc_hidden_proto and libc_hidden_def.
Tested for x86_64 (both that it removes this particular localplt
failure for -Os, and that the testsuite continues to pass without
-Os).
[BZ #15105]
* stdlib/atoi.c (atoi): Use libc_hidden_def.
* include/stdlib.h [!_ISOMAC] (atoi): Use libc_hidden_proto.
(cherry picked from commit 20602c72fa54bc0923314820ec8148186096bf3b)
Diff:
---
include/stdlib.h | 2 ++
stdlib/atoi.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/stdlib.h b/include/stdlib.h
index 5974fb3d24..114e12d255 100644
--- a/include/stdlib.h
+++ b/include/stdlib.h
@@ -210,6 +210,8 @@ libc_hidden_proto (strtoll)
libc_hidden_proto (strtoul)
libc_hidden_proto (strtoull)
+libc_hidden_proto (atoi)
+
extern float __strtof_nan (const char *, char **, char);
extern double __strtod_nan (const char *, char **, char);
extern long double __strtold_nan (const char *, char **, char);
diff --git a/stdlib/atoi.c b/stdlib/atoi.c
index a6c3f1d547..c42858494f 100644
--- a/stdlib/atoi.c
+++ b/stdlib/atoi.c
@@ -26,3 +26,4 @@ atoi (const char *nptr)
{
return (int) strtol (nptr, (char **) NULL, 10);
}
+libc_hidden_def (atoi)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-19 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 22:40 [glibc/google/grte/v5-2.27/master] Use libc_hidden_* for atoi (bug 15105) Fangrui Song
2021-11-19 21:22 Fangrui Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).