public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Fangrui Song <maskray@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/google/grte/v5-2.27/master] Use libc_hidden_* for __cmsg_nxthdr (bug 15105).
Date: Fri, 19 Nov 2021 21:21:52 +0000 (GMT)	[thread overview]
Message-ID: <20211119212152.709573858010@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=633d14073f5d2f257e12ceffcdcd2ada51483af5

commit 633d14073f5d2f257e12ceffcdcd2ada51483af5
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Feb 15 20:59:12 2018 +0000

    Use libc_hidden_* for __cmsg_nxthdr (bug 15105).
    
    Among other localplt test failures when building with -Os, there are
    libc.so PLT references for __cmsg_nxthdr.  This is a simple case of a
    function that is inlined for -O2 but not for -Os; this patch adds
    libc_hidden_proto / libc_hidden_def for it to avoid a localplt failure
    even when it is not inlined.
    
    Tested for x86_64 (both that it removes this particular localplt
    failure for -Os - but other such failures remain so the bug can't yet
    be closed - and that the testsuite continues to pass without -Os).
    
            [BZ #15105]
            * include/sys/socket.h [!_ISOMAC] (__cmsg_nxthdr): Use
            libc_hidden_proto.
            * sysdeps/unix/sysv/linux/cmsg_nxthdr.c (__cmsg_nxthdr): Use
            libc_hidden_def.
    
    (cherry picked from commit e4452a2d19279d4c90bcafe09ec3cbfd3efe9b6a)

Diff:
---
 include/sys/socket.h                  | 2 ++
 sysdeps/unix/sysv/linux/cmsg_nxthdr.c | 1 +
 2 files changed, 3 insertions(+)

diff --git a/include/sys/socket.h b/include/sys/socket.h
index baec6e6439..26db0e0d77 100644
--- a/include/sys/socket.h
+++ b/include/sys/socket.h
@@ -154,5 +154,7 @@ libc_hidden_proto (__libc_sa_len)
 # define SA_LEN(_x)      __libc_sa_len((_x)->sa_family)
 #endif
 
+libc_hidden_proto (__cmsg_nxthdr)
+
 #endif
 #endif
diff --git a/sysdeps/unix/sysv/linux/cmsg_nxthdr.c b/sysdeps/unix/sysv/linux/cmsg_nxthdr.c
index fa0468efda..bab0be6884 100644
--- a/sysdeps/unix/sysv/linux/cmsg_nxthdr.c
+++ b/sysdeps/unix/sysv/linux/cmsg_nxthdr.c
@@ -37,3 +37,4 @@ __cmsg_nxthdr (struct msghdr *mhdr, struct cmsghdr *cmsg)
     return NULL;
   return cmsg;
 }
+libc_hidden_def (__cmsg_nxthdr)


             reply	other threads:[~2021-11-19 21:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 21:21 Fangrui Song [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-15 22:40 Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119212152.709573858010@sourceware.org \
    --to=maskray@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).