From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1039) id 354653842400; Fri, 28 Jan 2022 00:39:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 354653842400 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: H.J. Lu To: glibc-cvs@sourceware.org Subject: [glibc/release/2.30/master] test-strnlen.c: Check that strnlen won't go beyond the maximum length X-Act-Checkin: glibc X-Git-Author: H.J. Lu X-Git-Refname: refs/heads/release/2.30/master X-Git-Oldrev: ad65f574aaf2b36c2be667a0a8f0a4f6f9411407 X-Git-Newrev: 84619864c6c2f9bda36e7a88880fc35a4eb649a7 Message-Id: <20220128003904.354653842400@sourceware.org> Date: Fri, 28 Jan 2022 00:39:04 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 00:39:04 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=84619864c6c2f9bda36e7a88880fc35a4eb649a7 commit 84619864c6c2f9bda36e7a88880fc35a4eb649a7 Author: H.J. Lu Date: Sat Mar 27 09:06:39 2021 -0700 test-strnlen.c: Check that strnlen won't go beyond the maximum length Place strings ending at page boundary without the null byte. If an implementation goes beyond EXP_LEN, it will trigger the segfault. (cherry picked from commit cb882b21b63606aabd6e55afe23b42434d95f2ef) Diff: --- string/test-strnlen.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/string/test-strnlen.c b/string/test-strnlen.c index a4cb3afdcf..f7d0896f47 100644 --- a/string/test-strnlen.c +++ b/string/test-strnlen.c @@ -198,6 +198,35 @@ do_page_tests (void) } } +/* Tests meant to unveil fail on implementations that access bytes + beyond the maxium length. */ + +static void +do_page_2_tests (void) +{ + size_t i, exp_len, offset; + size_t last_offset = page_size / sizeof (CHAR); + + CHAR *s = (CHAR *) buf2; + MEMSET (s, 65, last_offset); + + /* Place short strings ending at page boundary without the null + byte. */ + offset = last_offset; + for (i = 0; i < 128; i++) + { + /* Decrease offset to stress several sizes and alignments. */ + offset--; + exp_len = last_offset - offset; + FOR_EACH_IMPL (impl, 0) + { + /* If an implementation goes beyond EXP_LEN, it will trigger + the segfault. */ + do_one_test (impl, (CHAR *) (s + offset), exp_len, exp_len); + } + } +} + int test_main (void) { @@ -244,6 +273,7 @@ test_main (void) do_random_tests (); do_page_tests (); + do_page_2_tests (); return ret; }