public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Raoni Fassina Firmino <raoni@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/ibm/2.30/master] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex
Date: Fri, 25 Feb 2022 13:48:18 +0000 (GMT)	[thread overview]
Message-ID: <20220225134818.AE8E3385801D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=87a18fc33ab428f842ddd844b63691e19ea76e2d

commit 87a18fc33ab428f842ddd844b63691e19ea76e2d
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Apr 19 07:07:21 2021 -0700

    x86-64: Require BMI2 for __strlen_evex and __strnlen_evex
    
    Since __strlen_evex and __strnlen_evex added by
    
    commit 1fd8c163a83d96ace1ff78fa6bac7aee084f6f77
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Fri Mar 5 06:24:52 2021 -0800
    
        x86-64: Add ifunc-avx2.h functions with 256-bit EVEX
    
    use sarx:
    
    c4 e2 6a f7 c0          sarx   %edx,%eax,%eax
    
    require BMI2 for __strlen_evex and __strnlen_evex in ifunc-impl-list.c.
    ifunc-avx2.h already requires BMI2 for EVEX implementation.
    
    (cherry picked from commit 55bf411b451c13f0fb7ff3d3bf9a820020b45df1)

Diff:
---
 sysdeps/x86_64/multiarch/ifunc-impl-list.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
index b0ae7ed0da..bfe1a4ce53 100644
--- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
+++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
@@ -293,7 +293,8 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
 			      __strlen_avx2_rtm)
 	      IFUNC_IMPL_ADD (array, i, strlen,
 			      (HAS_ARCH_FEATURE (AVX512VL_Usable)
-			       && HAS_ARCH_FEATURE (AVX512BW_Usable)),
+			       && HAS_ARCH_FEATURE (AVX512BW_Usable)
+			       && HAS_CPU_FEATURE (BMI2)),
 			      __strlen_evex)
 	      IFUNC_IMPL_ADD (array, i, strlen, 1, __strlen_sse2))
 
@@ -308,7 +309,8 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
 			      __strnlen_avx2_rtm)
 	      IFUNC_IMPL_ADD (array, i, strnlen,
 			      (HAS_ARCH_FEATURE (AVX512VL_Usable)
-			       && HAS_ARCH_FEATURE (AVX512BW_Usable)),
+			       && HAS_ARCH_FEATURE (AVX512BW_Usable)
+			       && HAS_CPU_FEATURE (BMI2)),
 			      __strnlen_evex)
 	      IFUNC_IMPL_ADD (array, i, strnlen, 1, __strnlen_sse2))


                 reply	other threads:[~2022-02-25 13:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225134818.AE8E3385801D@sourceware.org \
    --to=raoni@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).