From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2206) id 9FE133858420; Tue, 1 Mar 2022 02:40:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FE133858420 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Siddhesh Poyarekar To: glibc-cvs@sourceware.org Subject: [glibc/siddhesh/gai-cleanup2] nptl: Fix cleanups for stack grows up [BZ# 28899] X-Act-Checkin: glibc X-Git-Author: John David Anglin X-Git-Refname: refs/heads/siddhesh/gai-cleanup2 X-Git-Oldrev: ca7334d34b7811fc261c84c498fd4a19acd70530 X-Git-Newrev: 2bbc694df279020a6620096d31c1e05c93966f9b Message-Id: <20220301024021.9FE133858420@sourceware.org> Date: Tue, 1 Mar 2022 02:40:21 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 02:40:21 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2bbc694df279020a6620096d31c1e05c93966f9b commit 2bbc694df279020a6620096d31c1e05c93966f9b Author: John David Anglin Date: Mon Feb 28 15:47:38 2022 +0000 nptl: Fix cleanups for stack grows up [BZ# 28899] _STACK_GROWS_DOWN is defined to 0 when the stack grows up. The code in unwind.c used `#ifdef _STACK_GROWS_DOWN' to selct the stack grows down define for FRAME_LEFT. As a result, the _STACK_GROWS_DOWN define was always selected and cleanups were incorrectly sequenced when the stack grows up. Diff: --- nptl/unwind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nptl/unwind.c b/nptl/unwind.c index c3563e3467..33b0d87579 100644 --- a/nptl/unwind.c +++ b/nptl/unwind.c @@ -25,7 +25,7 @@ #include #include -#ifdef _STACK_GROWS_DOWN +#if _STACK_GROWS_DOWN # define FRAME_LEFT(frame, other, adj) \ ((uintptr_t) frame - adj >= (uintptr_t) other - adj) #elif _STACK_GROWS_UP