public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] Disable use of -fsignaling-nans if compiler does not support it Date: Fri, 11 Mar 2022 17:21:04 +0000 (GMT) [thread overview] Message-ID: <20220311172104.ED91C3858037@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e7890cebbfae9b42c560bb2390c2cb7258079422 commit e7890cebbfae9b42c560bb2390c2cb7258079422 Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Mon Mar 7 15:09:53 2022 -0300 Disable use of -fsignaling-nans if compiler does not support it Diff: --- config.make.in | 1 + configure | 22 ++++++++++++++++++++ configure.ac | 9 ++++++++ math/Makefile | 14 ++++++------- sysdeps/powerpc/nofpu/Makefile | 24 +++++++++++----------- .../powerpc32/power4/fpu/multiarch/Makefile | 4 ++-- .../powerpc/powerpc64/be/fpu/multiarch/Makefile | 4 ++-- .../powerpc/powerpc64/le/fpu/multiarch/Makefile | 4 ++-- 8 files changed, 57 insertions(+), 25 deletions(-) diff --git a/config.make.in b/config.make.in index 6d43e691f7..c7c0d7ca84 100644 --- a/config.make.in +++ b/config.make.in @@ -42,6 +42,7 @@ asflags-cpu = @libc_cv_cc_submachine@ config-extra-cflags = @libc_extra_cflags@ config-extra-cppflags = @libc_extra_cppflags@ config-cflags-nofma = @libc_cv_cc_nofma@ +config-cflags-signaling-nans = @libc_cv_cc_signaling_nans@ defines = @DEFINES@ sysheaders = @sysheaders@ diff --git a/configure b/configure index 0d7034c5c7..2120961632 100755 --- a/configure +++ b/configure @@ -617,6 +617,7 @@ have_libcap have_libaudit LIBGD libc_cv_cc_loop_to_function +libc_cv_cc_signaling_nans libc_cv_cc_submachine libc_cv_cc_nofma libc_cv_mtls_dialect_gnu2 @@ -6521,6 +6522,27 @@ $as_echo "$libc_cv_cc_submachine" >&6; } fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for compiler option that ssumesIEEE signaling NaNs may generate user-visible traps" >&5 +$as_echo_n "checking for compiler option that ssumesIEEE signaling NaNs may generate user-visible traps... " >&6; } +if ${libc_cv_cc_signaling_nans+:} false; then : + $as_echo_n "(cached) " >&6 +else + if { ac_try='${CC-cc} -Werror -fsignaling-nans -xc /dev/null -S -o /dev/null' + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 + (eval $ac_try) 2>&5 + ac_status=$? + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 + test $ac_status = 0; }; }; then : + libc_cv_cc_signaling_nans=-fsignaling-nans +else + libc_cv_cc_signaling_nans= +fi + +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_cc_signaling_nans" >&5 +$as_echo "$libc_cv_cc_signaling_nans" >&6; } + + { $as_echo "$as_me:${as_lineno-$LINENO}: checking if $CC accepts -fno-tree-loop-distribute-patterns with \ __attribute__ ((__optimize__))" >&5 $as_echo_n "checking if $CC accepts -fno-tree-loop-distribute-patterns with \ diff --git a/configure.ac b/configure.ac index 4056acb090..89f7007414 100644 --- a/configure.ac +++ b/configure.ac @@ -1601,6 +1601,15 @@ if test -n "$submachine"; then fi AC_SUBST(libc_cv_cc_submachine) +dnl Determine if compiler supports -fsignaling-nans +AC_CACHE_CHECK([for compiler option that ssumesIEEE signaling NaNs may generate user-visible traps], + libc_cv_cc_signaling_nans, [dnl +LIBC_TRY_CC_OPTION([-Werror -fsignaling-nans], + [libc_cv_cc_signaling_nans=-fsignaling-nans], + [libc_cv_cc_signaling_nans=]) +]) +AC_SUBST(libc_cv_cc_signaling_nans) + AC_CACHE_CHECK(if $CC accepts -fno-tree-loop-distribute-patterns with \ __attribute__ ((__optimize__)), libc_cv_cc_loop_to_function, [dnl cat > conftest.c <<EOF diff --git a/math/Makefile b/math/Makefile index 7dae2313ba..a4932b3d0b 100644 --- a/math/Makefile +++ b/math/Makefile @@ -421,7 +421,7 @@ CFLAGS-test-float-vlen16-wrappers.c += $(float-vlen16-arch-ext-cflags) # exceptions. Thus both versions of the classification macros are # validated. libm-test-no-inline-cflags = -fno-inline -ffloat-store -fno-builtin \ - -fsignaling-nans + $(config-cflags-signaling-nans) CFLAGS-test-tgmath.c += -fno-builtin # The following testcase uses very long lines (>3 million), so it may take a # while to compile it. See: http://llvm.org/bugs/show_bug.cgi?id=14106 and @@ -430,7 +430,7 @@ CFLAGS-test-tgmath2.c += -fno-builtin CFLAGS-test-tgmath-ret.c += -fno-builtin CFLAGS-test-powl.c += -fno-builtin -CFLAGS-test-snan.c += -fsignaling-nans +CFLAGS-test-snan.c += $(config-cflags-signaling-nans) CFLAGS-test-signgam-uchar.c += -std=c99 CFLAGS-test-signgam-uchar-init.c += -std=c99 @@ -456,7 +456,7 @@ CFLAGS-test-iszero-excess-precision.c += -fexcess-precision=standard CFLAGS-test-iseqsig-excess-precision.c += -fexcess-precision=standard CFLAGS-test-flt-eval-method.c += -fexcess-precision=standard -CFLAGS-test-fe-snans-always-signal.c += -fsignaling-nans +CFLAGS-test-fe-snans-always-signal.c += $(config-cflags-signaling-nans) CFLAGS-test-nan-const.c += -fno-builtin @@ -768,10 +768,10 @@ endif # These files quiet sNaNs in a way that is optimized away without # -fsignaling-nans. -CFLAGS-s_modf.c += -fsignaling-nans -CFLAGS-s_modff.c += -fsignaling-nans -CFLAGS-s_modfl.c += -fsignaling-nans -CFLAGS-s_modff128.c += -fsignaling-nans +CFLAGS-s_modf.c += $(config-cflags-signaling-nans) +CFLAGS-s_modff.c += $(config-cflags-signaling-nans) +CFLAGS-s_modfl.c += $(config-cflags-signaling-nans) +CFLAGS-s_modff128.c += $(config-cflags-signaling-nans) $(addprefix $(objpfx),\ $(filter-out $(tests-static) $(libm-tests-vector),\ diff --git a/sysdeps/powerpc/nofpu/Makefile b/sysdeps/powerpc/nofpu/Makefile index 3b51ff6d18..fa462339ba 100644 --- a/sysdeps/powerpc/nofpu/Makefile +++ b/sysdeps/powerpc/nofpu/Makefile @@ -27,18 +27,18 @@ CPPFLAGS += -I../soft-fp/ CFLAGS-e_atan2l.c += -fno-builtin-fabsl CFLAGS-e_hypotl.c += -fno-builtin-fabsl CFLAGS-e_powl.c += -fno-builtin-fabsl -CFLAGS-s_cacosl.c += -fsignaling-nans -CFLAGS-s_cacoshl.c += -fsignaling-nans -CFLAGS-s_casinhl.c += -fsignaling-nans -CFLAGS-s_catanl.c += -fsignaling-nans -CFLAGS-s_catanhl.c += -fsignaling-nans -CFLAGS-s_ccoshl.c += -fno-builtin-fabsl -fsignaling-nans -CFLAGS-s_cexpl.c += -fsignaling-nans -CFLAGS-s_csinhl.c += -fno-builtin-fabsl -fsignaling-nans -CFLAGS-s_clogl.c += -fno-builtin-fabsl -fsignaling-nans -CFLAGS-s_clog10l.c += -fno-builtin-fabsl -fsignaling-nans -CFLAGS-s_csinl.c += -fno-builtin-fabsl -fsignaling-nans -CFLAGS-s_csqrtl.c += -fno-builtin-fabsl -fsignaling-nans +CFLAGS-s_cacosl.c += $(config-cflags-signaling-nans) +CFLAGS-s_cacoshl.c += $(config-cflags-signaling-nans) +CFLAGS-s_casinhl.c += $(config-cflags-signaling-nans) +CFLAGS-s_catanl.c += $(config-cflags-signaling-nans) +CFLAGS-s_catanhl.c += $(config-cflags-signaling-nans) +CFLAGS-s_ccoshl.c += -fno-builtin-fabsl $(config-cflags-signaling-nans) +CFLAGS-s_cexpl.c += $(config-cflags-signaling-nans) +CFLAGS-s_csinhl.c += -fno-builtin-fabsl $(config-cflags-signaling-nans) +CFLAGS-s_clogl.c += -fno-builtin-fabsl $(config-cflags-signaling-nans) +CFLAGS-s_clog10l.c += -fno-builtin-fabsl $(config-cflags-signaling-nans) +CFLAGS-s_csinl.c += -fno-builtin-fabsl $(config-cflags-signaling-nans) +CFLAGS-s_csqrtl.c += -fno-builtin-fabsl $(config-cflags-signaling-nans) CFLAGS-w_acosl_compat.c += -fno-builtin-fabsl CFLAGS-w_asinl_compat.c += -fno-builtin-fabsl CFLAGS-w_atanhl_compat.c += -fno-builtin-fabsl diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile index 1de0f9b350..64317506c6 100644 --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile @@ -37,6 +37,6 @@ CFLAGS-s_logbf-power7.c = -mcpu=power7 # These files quiet sNaNs in a way that is optimized away without # -fsignaling-nans. -CFLAGS-s_modf-ppc32.c += -fsignaling-nans -CFLAGS-s_modff-ppc32.c += -fsignaling-nans +CFLAGS-s_modf-ppc32.c += $(config-cflags-signaling-nans) +CFLAGS-s_modff-ppc32.c += $(config-cflags-signaling-nans) endif diff --git a/sysdeps/powerpc/powerpc64/be/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc64/be/fpu/multiarch/Makefile index b27bad3ba4..36f4006059 100644 --- a/sysdeps/powerpc/powerpc64/be/fpu/multiarch/Makefile +++ b/sysdeps/powerpc/powerpc64/be/fpu/multiarch/Makefile @@ -62,6 +62,6 @@ CFLAGS-s_logb-power7.c = -mcpu=power7 # These files quiet sNaNs in a way that is optimized away without # -fsignaling-nans. -CFLAGS-s_modf-ppc64.c += -fsignaling-nans -CFLAGS-s_modff-ppc64.c += -fsignaling-nans +CFLAGS-s_modf-ppc64.c += $(config-cflags-signaling-nans) +CFLAGS-s_modff-ppc64.c += $(config-cflags-signaling-nans) endif diff --git a/sysdeps/powerpc/powerpc64/le/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc64/le/fpu/multiarch/Makefile index cc073b53d3..249850f410 100644 --- a/sysdeps/powerpc/powerpc64/le/fpu/multiarch/Makefile +++ b/sysdeps/powerpc/powerpc64/le/fpu/multiarch/Makefile @@ -130,8 +130,8 @@ generated += $(f128-march-routines) CFLAGS-float128-ifunc.c += $(type-float128-CFLAGS) $(no-gnu-attribute-CFLAGS) # Copy special CFLAGS for some functions -CFLAGS-s_modff128-power9.c += -fsignaling-nans -CFLAGS-m_modff128-power9.c += -fsignaling-nans +CFLAGS-s_modff128-power9.c += $(config-cflags-signaling-nans) +CFLAGS-m_modff128-power9.c += $(config-cflags-signaling-nans) # Generate ifunc wrapper files and target specific wrappers around # each routine above. Note, m_%.c files are fixed up to include
next reply other threads:[~2022-03-11 17:21 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-11 17:21 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-10-28 17:38 Adhemerval Zanella 2022-10-04 12:56 Adhemerval Zanella 2022-06-09 21:17 Adhemerval Zanella 2022-06-09 13:14 Adhemerval Zanella 2022-06-03 14:03 Adhemerval Zanella 2022-05-13 14:17 Adhemerval Zanella 2022-05-12 19:31 Adhemerval Zanella 2022-05-10 18:21 Adhemerval Zanella 2022-04-29 14:01 Adhemerval Zanella 2022-04-04 12:51 Adhemerval Zanella 2022-03-31 19:04 Adhemerval Zanella 2022-03-29 20:27 Adhemerval Zanella 2022-03-16 17:59 Adhemerval Zanella 2022-03-15 18:36 Adhemerval Zanella 2022-03-08 18:57 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220311172104.ED91C3858037@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).