public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] support: Fix support_process_state_wait path size calculation
Date: Wed, 23 Mar 2022 18:32:42 +0000 (GMT)	[thread overview]
Message-ID: <20220323183242.0102F3853804@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0374b487a71ad07005a816191dca829a7e6cdcae

commit 0374b487a71ad07005a816191dca829a7e6cdcae
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Mar 10 16:49:08 2022 -0300

    support: Fix support_process_state_wait path size calculation
    
    Use INT_STRLEN_BOUND to proper get the maximum pid_t size.  Also
    fix the wrong calculation (the 3 should multiply the sizeof (pid_t)).
    
    Checked on x86_64-linux-gnu.

Diff:
---
 support/support_process_state.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/support/support_process_state.c b/support/support_process_state.c
index 0dc608b468..ca86dc11e6 100644
--- a/support/support_process_state.c
+++ b/support/support_process_state.c
@@ -21,6 +21,7 @@
 #include <string.h>
 
 #include <array_length.h>
+#include <intprops.h>
 
 #include <support/process_state.h>
 #include <support/xstdio.h>
@@ -49,7 +50,7 @@ support_process_state_wait (pid_t pid, enum support_process_state state)
     { support_process_state_parked,       'P' },
   };
 
-  char spath[sizeof ("/proc/" + 3) * sizeof (pid_t) + sizeof ("/status") + 1];
+  char spath[sizeof ("/proc/") + INT_STRLEN_BOUND (pid_t) + sizeof ("/status") + 1];
   snprintf (spath, sizeof (spath), "/proc/%i/status", pid);
 
   FILE *fstatus = xfopen (spath, "r");


                 reply	other threads:[~2022-03-23 18:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220323183242.0102F3853804@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).