public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] debug: Improve fdelt_chk error message
Date: Mon, 28 Mar 2022 13:42:47 +0000 (GMT)	[thread overview]
Message-ID: <20220328134247.313FA385781A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=811c635dbae42a0ced67d2bffa8ad68b58d6e44e

commit 811c635dbae42a0ced67d2bffa8ad68b58d6e44e
Author: Cristian Rodríguez <crrodriguez@opensuse.org>
Date:   Sun Mar 13 18:40:24 2022 +0000

    debug: Improve fdelt_chk error message
    
    It is not a "buffer overflow detected" but an out of range
    bit on fd_set
    
    Signed-off-by: Cristian Rodríguez <crrodriguez@opensuse.org>
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Diff:
---
 debug/fdelt_chk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debug/fdelt_chk.c b/debug/fdelt_chk.c
index c5f16462ad..30f5a4bec1 100644
--- a/debug/fdelt_chk.c
+++ b/debug/fdelt_chk.c
@@ -15,6 +15,7 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
+#include <stdio.h>
 #include <sys/select.h>
 
 
@@ -22,7 +23,7 @@ long int
 __fdelt_chk (long int d)
 {
   if (d < 0 || d >= FD_SETSIZE)
-    __chk_fail ();
+    __fortify_fail ("bit out of range 0 - FD_SETSIZE on fd_set");
 
   return d / __NFDBITS;
 }


                 reply	other threads:[~2022-03-28 13:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328134247.313FA385781A@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).