From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id C5976385840C; Tue, 29 Mar 2022 20:28:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5976385840C Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] math: Suppress clang warning on math_check_force_underflow X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 586f51ce610989bd6b683ca5cb052a71307675ce X-Git-Newrev: 392b04f61235817fe1ed37ff5b7aaeeb916d1f50 Message-Id: <20220329202858.C5976385840C@sourceware.org> Date: Tue, 29 Mar 2022 20:28:58 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 20:28:59 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=392b04f61235817fe1ed37ff5b7aaeeb916d1f50 commit 392b04f61235817fe1ed37ff5b7aaeeb916d1f50 Author: Adhemerval Zanella Date: Thu Mar 10 13:53:13 2022 -0300 math: Suppress clang warning on math_check_force_underflow Diff: --- math/math-underflow.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/math/math-underflow.h b/math/math-underflow.h index c9d363ddd1..4bec3d349e 100644 --- a/math/math-underflow.h +++ b/math/math-underflow.h @@ -23,6 +23,7 @@ #include #include +#include #define fabs_tg(x) __MATH_TG ((x), (__typeof (x)) __builtin_fabs, (x)) @@ -37,10 +38,15 @@ #define min_of_type(x) __MATH_TG ((x), (__typeof (x)) min_of_type_, ()) /* If X (which is not a NaN) is subnormal, force an underflow - exception. */ + exception. + + clang issues a warning where _Generic is using a non expected + builtin which may cause truncation of value. */ #define math_check_force_underflow(x) \ do \ { \ + DIAG_PUSH_NEEDS_COMMENT_CLANG; \ + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wabsolute-value"); \ __typeof (x) force_underflow_tmp = (x); \ if (fabs_tg (force_underflow_tmp) \ < min_of_type (force_underflow_tmp)) \ @@ -49,6 +55,7 @@ = force_underflow_tmp * force_underflow_tmp; \ math_force_eval (force_underflow_tmp2); \ } \ + DIAG_POP_NEEDS_COMMENT_CLANG; \ } \ while (0) /* Likewise, but X is also known to be nonnegative. */