public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] math: Do not use __builtin_isnan on clang
Date: Mon,  4 Apr 2022 13:00:38 +0000 (GMT)	[thread overview]
Message-ID: <20220404130038.9D1DE3858413@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4582f5d789942b05135af5a397e224e281e08af0

commit 4582f5d789942b05135af5a397e224e281e08af0
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Apr 1 17:01:22 2022 -0300

    math: Do not use __builtin_isnan on clang
    
    It does not handle pseudo normal numbers.

Diff:
---
 math/math.h                                 | 3 +--
 sysdeps/ieee754/float128/float128_private.h | 2 +-
 sysdeps/ieee754/float128/s_isnanf128.c      | 4 ++++
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/math/math.h b/math/math.h
index 678102402c..8e64e2eb4f 100644
--- a/math/math.h
+++ b/math/math.h
@@ -1004,8 +1004,7 @@ enum
 
 /* Return nonzero value if X is a NaN.  We could use `fpclassify' but
    we already have this functions `__isnan' and it is faster.  */
-# if (__GNUC_PREREQ (4,4) && !defined __SUPPORT_SNAN__) \
-     || __glibc_clang_prereq (2,8)
+# if (__GNUC_PREREQ (4,4) && !defined __SUPPORT_SNAN__)
 #  define isnan(x) __builtin_isnan (x)
 # else
 #  define isnan(x) __MATH_TG ((x), __isnan, (x))
diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee754/float128/float128_private.h
index a74462575c..895890e2ad 100644
--- a/sysdeps/ieee754/float128/float128_private.h
+++ b/sysdeps/ieee754/float128/float128_private.h
@@ -346,7 +346,7 @@
 #define frexpl frexpf128
 #define getpayloadl getpayloadf128
 #define isinfl isinff128_do_not_use
-#define isnanl isnanf128_do_not_use
+#define isnanl isnanf128
 #define ldexpl ldexpf128
 #define llrintl llrintf128
 #define llroundl llroundf128
diff --git a/sysdeps/ieee754/float128/s_isnanf128.c b/sysdeps/ieee754/float128/s_isnanf128.c
index 59f71533ce..b73a4e80d7 100644
--- a/sysdeps/ieee754/float128/s_isnanf128.c
+++ b/sysdeps/ieee754/float128/s_isnanf128.c
@@ -11,7 +11,11 @@
 #include "../ldbl-128/s_isnanl.c"
 #if !IS_IN (libm)
 #include <float128-abi.h>
+#ifdef SHARED
 hidden_ver (__isnanf128_impl, __isnanf128)
+#else
+strong_alias (__isnanf128_impl, __isnanf128)
+#endif
 _weak_alias (__isnanf128_impl, isnanl)
 versioned_symbol (libc, __isnanf128_impl, __isnanf128, GLIBC_2_34);
 #if (SHLIB_COMPAT (libc, FLOAT128_VERSION_M, GLIBC_2_34))


             reply	other threads:[~2022-04-04 13:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 13:00 Adhemerval Zanella [this message]
2022-04-29 14:09 Adhemerval Zanella
2022-05-10 18:29 Adhemerval Zanella
2022-05-12 19:39 Adhemerval Zanella
2022-05-13 14:25 Adhemerval Zanella
2022-06-03 14:11 Adhemerval Zanella
2022-06-09 13:22 Adhemerval Zanella
2022-06-09 21:25 Adhemerval Zanella
2022-10-04 13:04 Adhemerval Zanella
2022-10-28 17:47 Adhemerval Zanella
2023-02-09 19:53 Adhemerval Zanella
2023-08-30 12:41 Adhemerval Zanella
2023-09-28 17:57 Adhemerval Zanella
2023-12-21 18:59 Adhemerval Zanella
2024-01-29 18:02 Adhemerval Zanella
2024-02-07 14:12 Adhemerval Zanella
2024-02-09 17:37 Adhemerval Zanella
2024-04-02 15:59 Adhemerval Zanella
2024-04-17 20:12 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220404130038.9D1DE3858413@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).