public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: H.J. Lu <hjl@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] x86-64: Fix SSE2 memcmp and SSSE3 memmove for x32
Date: Fri, 22 Apr 2022 18:54:26 +0000 (GMT)	[thread overview]
Message-ID: <20220422185426.37D323858C83@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8ea20ee5f6145de4bff9481d3e09ac36ba9df8f3

commit 8ea20ee5f6145de4bff9481d3e09ac36ba9df8f3
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Apr 22 10:53:13 2022 -0700

    x86-64: Fix SSE2 memcmp and SSSE3 memmove for x32
    
    Clear the upper 32 bits in RDX (memory size) for x32 to fix
    
    FAIL: string/tst-size_t-memcmp
    FAIL: string/tst-size_t-memcmp-2
    FAIL: string/tst-size_t-memcpy
    FAIL: wcsmbs/tst-size_t-wmemcmp
    
    on x32 introduced by
    
    8804157ad9 x86: Optimize memcmp SSE2 in memcmp.S
    26b2478322 x86: Reduce code size of mem{move|pcpy|cpy}-ssse3
    
    Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>

Diff:
---
 sysdeps/x86_64/memcmp.S                  | 4 ++++
 sysdeps/x86_64/multiarch/memmove-ssse3.S | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/sysdeps/x86_64/memcmp.S b/sysdeps/x86_64/memcmp.S
index b153694048..5718a7da86 100644
--- a/sysdeps/x86_64/memcmp.S
+++ b/sysdeps/x86_64/memcmp.S
@@ -46,6 +46,10 @@
 
 	.text
 ENTRY(MEMCMP)
+# ifdef __ILP32__
+	/* Clear the upper 32 bits.  */
+	movl	%edx, %edx
+# endif
 #ifdef USE_AS_WMEMCMP
 	/* Use 0xffff to test for mismatches on pmovmskb bitmask. Store
 	   in ecx for code size. This is preferable to using `incw` as
diff --git a/sysdeps/x86_64/multiarch/memmove-ssse3.S b/sysdeps/x86_64/multiarch/memmove-ssse3.S
index 215583e7bd..310ff62b86 100644
--- a/sysdeps/x86_64/multiarch/memmove-ssse3.S
+++ b/sysdeps/x86_64/multiarch/memmove-ssse3.S
@@ -27,6 +27,10 @@ ENTRY(MEMMOVE_CHK)
 END(MEMMOVE_CHK)
 
 ENTRY_P2ALIGN(MEMMOVE, 6)
+# ifdef __ILP32__
+	/* Clear the upper 32 bits.  */
+	movl	%edx, %edx
+# endif
 	movq	%rdi, %rax
 L(start):
 	cmpq	$16, %rdx


                 reply	other threads:[~2022-04-22 18:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220422185426.37D323858C83@sourceware.org \
    --to=hjl@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).