From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7852) id 352443856253; Wed, 27 Apr 2022 02:01:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 352443856253 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Sunil Pandey To: glibc-cvs@sourceware.org Subject: [glibc/release/2.34/master] x86-64: Replace movzx with movzbl X-Act-Checkin: glibc X-Git-Author: Fangrui Song X-Git-Refname: refs/heads/release/2.34/master X-Git-Oldrev: a182bb7a3922404f79def09d79ef89678b4049f0 X-Git-Newrev: 2e64237a8744dd50f9222293275fa52e7248ff76 Message-Id: <20220427020102.352443856253@sourceware.org> Date: Wed, 27 Apr 2022 02:01:02 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 02:01:02 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2e64237a8744dd50f9222293275fa52e7248ff76 commit 2e64237a8744dd50f9222293275fa52e7248ff76 Author: Fangrui Song Date: Tue Nov 2 20:59:52 2021 -0700 x86-64: Replace movzx with movzbl Clang cannot assemble movzx in the AT&T dialect mode. ../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction movzx (%rsi), %ecx ^~~~ Change movzx to movzbl, which follows the AT&T dialect and is used elsewhere in the file. Reviewed-by: H.J. Lu (cherry picked from commit 6720d36b6623c5e48c070d86acf61198b33e144e) Diff: --- sysdeps/x86_64/multiarch/strcmp-sse42.S | 4 ++-- sysdeps/x86_64/strcmp.S | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S index bc19547b09..6197a723b9 100644 --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S @@ -1771,8 +1771,8 @@ LABEL(strcmp_exitz): .p2align 4 // XXX Same as code above LABEL(Byte0): - movzx (%rsi), %ecx - movzx (%rdi), %eax + movzbl (%rsi), %ecx + movzbl (%rdi), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S index 824e648230..7f8a1bc756 100644 --- a/sysdeps/x86_64/strcmp.S +++ b/sysdeps/x86_64/strcmp.S @@ -2232,8 +2232,8 @@ LABEL(strcmp_exitz): .p2align 4 LABEL(Byte0): - movzx (%rsi), %ecx - movzx (%rdi), %eax + movzbl (%rsi), %ecx + movzbl (%rdi), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx