public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/fw/2.32-zen-memcpy-revert] Temporarily revert "x86: Optimizing memcpy for AMD Zen architecture."
Date: Mon,  2 May 2022 14:04:15 +0000 (GMT)	[thread overview]
Message-ID: <20220502140415.A84C73857815@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=537fc6aa6969d5612e953f40d2c4853f33bc1a76

commit 537fc6aa6969d5612e953f40d2c4853f33bc1a76
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon May 2 16:03:07 2022 +0200

    Temporarily revert "x86: Optimizing memcpy for AMD Zen architecture."
    
    This reverts commit 8813b2682e4094e43b0cf1634e99619f1b8b2c62.
    
    This commit will be backported again, this time in sequence, and more
    closely following the upstream version.

Diff:
---
 sysdeps/x86/cacheinfo.c | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
index 3fb4a028d8..dadec5d58f 100644
--- a/sysdeps/x86/cacheinfo.c
+++ b/sysdeps/x86/cacheinfo.c
@@ -808,7 +808,7 @@ init_cacheinfo (void)
 	      threads = 1 << ((ecx >> 12) & 0x0f);
 	    }
 
-	  if (threads == 0 || cpu_features->basic.family >= 0x17)
+	  if (threads == 0)
 	    {
 	      /* If APIC ID width is not available, use logical
 		 processor count.  */
@@ -823,22 +823,8 @@ init_cacheinfo (void)
 	  if (threads > 0)
 	    shared /= threads;
 
-	  /* Get shared cache per ccx for Zen architectures.  */
-	  if (cpu_features->basic.family >= 0x17)
-	    {
-	      unsigned int eax;
-
-	      /* Get number of threads share the L3 cache in CCX.  */
-	      __cpuid_count (0x8000001D, 0x3, eax, ebx, ecx, edx);
-
-	      unsigned int threads_per_ccx = ((eax >> 14) & 0xfff) + 1;
-	      shared *= threads_per_ccx;
-	    }
-	  else
-	    {
-	      /* Account for exclusive L2 and L3 caches.  */
-	      shared += core;
-            }
+	  /* Account for exclusive L2 and L3 caches.  */
+	  shared += core;
 	}
     }


                 reply	other threads:[~2022-05-02 14:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502140415.A84C73857815@sourceware.org \
    --to=fw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).