public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Sunil Pandey <skpgkp2@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/release/2.33/master] x86: Set rep_movsb_threshold to 2112 on processors with FSRM
Date: Mon,  2 May 2022 21:29:38 +0000 (GMT)	[thread overview]
Message-ID: <20220502212938.7DD3D3857418@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6d74f1b7126b8a1d1b4ee8859826a8bac22f3a71

commit 6d74f1b7126b8a1d1b4ee8859826a8bac22f3a71
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Apr 30 05:58:59 2021 -0700

    x86: Set rep_movsb_threshold to 2112 on processors with FSRM
    
    The glibc memcpy benchmark on Intel Core i7-1065G7 (Ice Lake) showed
    that REP MOVSB became faster after 2112 bytes:
    
                                          Vector Move       REP MOVSB
    length=2112, align1=0, align2=0:        24.20             24.40
    length=2112, align1=1, align2=0:        26.07             23.13
    length=2112, align1=0, align2=1:        27.18             28.13
    length=2112, align1=1, align2=1:        26.23             25.16
    length=2176, align1=0, align2=0:        23.18             22.52
    length=2176, align1=2, align2=0:        25.45             22.52
    length=2176, align1=0, align2=2:        27.14             27.82
    length=2176, align1=2, align2=2:        22.73             25.56
    length=2240, align1=0, align2=0:        24.62             24.25
    length=2240, align1=3, align2=0:        29.77             27.15
    length=2240, align1=0, align2=3:        35.55             29.93
    length=2240, align1=3, align2=3:        34.49             25.15
    length=2304, align1=0, align2=0:        34.75             26.64
    length=2304, align1=4, align2=0:        32.09             22.63
    length=2304, align1=0, align2=4:        28.43             31.24
    
    Use REP MOVSB for data size > 2112 bytes in memcpy on processors with
    fast short REP MOVSB (FSRM).
    
            * sysdeps/x86/dl-cacheinfo.h (dl_init_cacheinfo): Set
            rep_movsb_threshold to 2112 on processors with fast short REP
            MOVSB (FSRM).
    
    (cherry picked from commit cf2c57526ba4b57e6863ad4db8a868e2678adce8)

Diff:
---
 sysdeps/x86/dl-cacheinfo.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sysdeps/x86/dl-cacheinfo.h b/sysdeps/x86/dl-cacheinfo.h
index d9944250fc..e6c94dfd02 100644
--- a/sysdeps/x86/dl-cacheinfo.h
+++ b/sysdeps/x86/dl-cacheinfo.h
@@ -891,6 +891,10 @@ dl_init_cacheinfo (struct cpu_features *cpu_features)
       minimum_rep_movsb_threshold = 16 * 8;
 #endif
     }
+  /* NB: The default REP MOVSB threshold is 2112 on processors with fast
+     short REP MOVSB (FSRM).  */
+  if (CPU_FEATURE_USABLE_P (cpu_features, FSRM))
+    rep_movsb_threshold = 2112;
 
   unsigned long int rep_movsb_stop_threshold;
   /* ERMS feature is implemented from AMD Zen3 architecture and it is


                 reply	other threads:[~2022-05-02 21:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502212938.7DD3D3857418@sourceware.org \
    --to=skpgkp2@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).