public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] string: Suppress clang -Wsuspicious-bzero on tester
Date: Fri, 13 May 2022 14:22:44 +0000 (GMT) [thread overview]
Message-ID: <20220513142244.4F54F396E474@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9ad4abe185b668a8af3752405610be4acff2aaee
commit 9ad4abe185b668a8af3752405610be4acff2aaee
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Mar 24 18:08:41 2022 -0300
string: Suppress clang -Wsuspicious-bzero on tester
Diff:
---
string/tester.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/string/tester.c b/string/tester.c
index eed76239f5..46a24e7417 100644
--- a/string/tester.c
+++ b/string/tester.c
@@ -370,28 +370,48 @@ test_strncat (void)
mechanism. */
it = "strncat";
(void) strcpy (one, "ijk");
+ /* clang complains that size argument is too large for the destination
+ buffer. */
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
check (strncat (one, "lmn", 99) == one, 1); /* Returned value. */
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "ijklmn", 2); /* Basic test. */
(void) strcpy (one, "x");
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
(void) strncat (one, "yz", 99);
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "xyz", 3); /* Writeover. */
equal (one+4, "mn", 4); /* Wrote too much? */
(void) strcpy (one, "gh");
(void) strcpy (two, "ef");
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
(void) strncat (one, two, 99);
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "ghef", 5); /* Basic test encore. */
equal (two, "ef", 6); /* Stomped on source? */
(void) strcpy (one, "");
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
(void) strncat (one, "", 99);
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "", 7); /* Boundary conditions. */
(void) strcpy (one, "ab");
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
(void) strncat (one, "", 99);
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "ab", 8);
(void) strcpy (one, "");
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
(void) strncat (one, "cd", 99);
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "cd", 9);
(void) strcpy (one, "ab");
@@ -404,7 +424,10 @@ test_strncat (void)
(void) strncat (one, "gh", 2);
equal (one, "abcdgh", 12); /* Count and length equal. */
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source");
(void) strncat (one, "ij", (size_t)-1); /* set sign bit in count */
+ DIAG_POP_NEEDS_COMMENT_CLANG;
equal (one, "abcdghij", 13);
int ntest = 14;
@@ -1408,7 +1431,12 @@ test_bzero (void)
equal(one+4, "ef", 3);
(void) strcpy(one, "abcdef");
+
+ DIAG_PUSH_NEEDS_COMMENT_CLANG;
+ /* clang complains about the 0 size argument for bzero. */
+ DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsuspicious-bzero");
bzero(one+2, 0);
+ DIAG_POP_NEEDS_COMMENT_CLANG
equal(one, "abcdef", 4); /* Zero-length copy. */
}
next reply other threads:[~2022-05-13 14:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 14:22 Adhemerval Zanella [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-25 20:24 Adhemerval Zanella
2024-04-17 20:10 Adhemerval Zanella
2024-04-02 15:56 Adhemerval Zanella
2024-02-09 17:34 Adhemerval Zanella
2024-02-07 14:10 Adhemerval Zanella
2024-01-29 18:00 Adhemerval Zanella
2023-12-21 18:56 Adhemerval Zanella
2023-09-28 17:55 Adhemerval Zanella
2023-08-30 12:39 Adhemerval Zanella
2023-02-09 19:51 Adhemerval Zanella
2022-10-28 17:44 Adhemerval Zanella
2022-10-04 13:02 Adhemerval Zanella
2022-06-09 21:22 Adhemerval Zanella
2022-06-09 13:19 Adhemerval Zanella
2022-06-03 14:08 Adhemerval Zanella
2022-05-12 19:36 Adhemerval Zanella
2022-05-10 18:26 Adhemerval Zanella
2022-04-29 14:06 Adhemerval Zanella
2022-04-04 12:57 Adhemerval Zanella
2022-03-31 19:09 Adhemerval Zanella
2022-03-29 20:32 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513142244.4F54F396E474@sourceware.org \
--to=azanella@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).