From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id D04523857823; Tue, 17 May 2022 09:58:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D04523857823 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc/release/2.35/master] Linux: Include in dl-sysdep.c only for SHARED X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/release/2.35/master X-Git-Oldrev: 788eb21ff0deb0ef7cb203de5e4df7898ca1d82c X-Git-Newrev: 76304dfdaf0b979fdb2797787ec75e46aea0e8b4 Message-Id: <20220517095819.D04523857823@sourceware.org> Date: Tue, 17 May 2022 09:58:19 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 09:58:19 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=76304dfdaf0b979fdb2797787ec75e46aea0e8b4 commit 76304dfdaf0b979fdb2797787ec75e46aea0e8b4 Author: Florian Weimer Date: Fri Feb 11 19:03:04 2022 +0100 Linux: Include in dl-sysdep.c only for SHARED Otherwise, on POWER ends up being included twice, once in dl-sysdep.c, once in dl-support.c. That leads to a linker failure due to multiple definitions of _dl_cache_line_size. Fixes commit d96d2995c1121d3310102afda2deb1f35761b5e6 ("Revert "Linux: Consolidate auxiliary vector parsing"). (cherry picked from commit 098c795e85fbd05c5ef59c2d0ce59529331bea27) Diff: --- sysdeps/unix/sysv/linux/dl-sysdep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/dl-sysdep.c b/sysdeps/unix/sysv/linux/dl-sysdep.c index 5e71704fcf..8ad72c4b7b 100644 --- a/sysdeps/unix/sysv/linux/dl-sysdep.c +++ b/sysdeps/unix/sysv/linux/dl-sysdep.c @@ -18,7 +18,6 @@ #include <_itoa.h> #include -#include #include #include #include @@ -46,6 +45,8 @@ #include #ifdef SHARED +# include + extern char **_environ attribute_hidden; extern char _end[] attribute_hidden;