public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] csky: Remove _dl_skip_args usage
Date: Mon, 30 May 2022 20:49:21 +0000 (GMT)	[thread overview]
Message-ID: <20220530204921.08F42384B835@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=00477963c6a5abd3075044f180d4d0d122a77de0

commit 00477963c6a5abd3075044f180d4d0d122a77de0
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu May 26 13:06:06 2022 -0300

    csky: Remove _dl_skip_args usage
    
    Since ad43cac44a the generic code already shuffles the argv/envp/auxv
    on the stack to remove the ld.so own arguments and thus _dl_skip_args
    is always 0.  It makes the fixup_stack branch ununsed.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 sysdeps/csky/dl-machine.h | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/sysdeps/csky/dl-machine.h b/sysdeps/csky/dl-machine.h
index f81448a141..48787ce3c7 100644
--- a/sysdeps/csky/dl-machine.h
+++ b/sysdeps/csky/dl-machine.h
@@ -113,11 +113,7 @@ _start:\n\
 	addu	t1, gb\n\
 	jsr	t1\n\
 _dl_start_user:\n\
-	/* get _dl_skip_args */    \n\
-	lrw	r11, _dl_skip_args@GOTOFF\n\
-	addu	r11, gb\n\
-	ldw	r11, (r11, 0)\n\
-	/* store program entry address in r11 */ \n\
+	/* store program entry address in r10 */ \n\
 	mov	r10, a0\n\
 	/* Get argc */\n\
 	ldw	a1, (sp, 0)\n\
@@ -125,8 +121,6 @@ _dl_start_user:\n\
 	mov	a2, sp\n\
 	addi	a2, 4\n\
 	cmpnei	r11, 0\n\
-	bt	.L_fixup_stack\n\
-.L_done_fixup:\n\
 	mov	a3, a1\n\
 	lsli	a3, 2\n\
 	add	a3, a2\n\
@@ -141,17 +135,6 @@ _dl_start_user:\n\
 	lrw	a0, _dl_fini@GOTOFF\n\
 	addu	a0, gb\n\
 	jmp	r10\n\
-.L_fixup_stack:\n\
-	subu	a1, r11\n\
-	lsli	r11, 2\n\
-	addu	sp, r11\n\
-	stw	a1, (sp, 0)\n\
-	mov	a2, sp\n\
-	addi	a2, 4\n\
-	lrw	a3, _dl_argv@GOTOFF\n\
-	addu	a3, gb\n\
-	stw	a2, (a3, 0)\n\
-	br	.L_done_fixup\n\
 ");
 
 /* ELF_RTYPE_CLASS_PLT iff TYPE describes relocation of a PLT entry or


                 reply	other threads:[~2022-05-30 20:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220530204921.08F42384B835@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).