public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] microblaze: Remove _dl_skip_args usage Date: Mon, 30 May 2022 20:49:46 +0000 (GMT) [thread overview] Message-ID: <20220530204946.9223C384F01C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=90cf8e6f0a459ced1a3ed2ab54030ed41e3d639d commit 90cf8e6f0a459ced1a3ed2ab54030ed41e3d639d Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Thu May 26 13:11:17 2022 -0300 microblaze: Remove _dl_skip_args usage Since ad43cac44a the generic code already shuffles the argv/envp/auxv on the stack to remove the ld.so own arguments and thus _dl_skip_args is always 0. So there is no need to adjust the argc or argv. Checked with qemu-user that arguments are correctly passed on both constructors and main program. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Diff: --- sysdeps/microblaze/dl-machine.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sysdeps/microblaze/dl-machine.h b/sysdeps/microblaze/dl-machine.h index fd996d6ff1..e6e4e13fa2 100644 --- a/sysdeps/microblaze/dl-machine.h +++ b/sysdeps/microblaze/dl-machine.h @@ -117,12 +117,7 @@ _start:\n\ _dl_start_user:\n\ mfs r20,rpc\n\ addik r20,r20,_GLOBAL_OFFSET_TABLE_+8\n\ - lwi r4,r20,_dl_skip_args@GOTOFF\n\ lwi r5,r1,24\n\ - rsubk r5,r4,r5\n\ - addk r4,r4,r4\n\ - addk r4,r4,r4\n\ - addk r1,r1,r4\n\ swi r5,r1,24\n\ swi r3,r1,20\n\ addk r6,r5,r0\n\
reply other threads:[~2022-05-30 20:49 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220530204946.9223C384F01C@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).